Bug 260333 - sysutils/acpi_call: error: use of undeclared identifier 'MAXPATHLEN'
Summary: sysutils/acpi_call: error: use of undeclared identifier 'MAXPATHLEN'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-11 07:15 UTC by Tomoaki AOKI
Modified: 2021-12-22 08:58 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gelraen.ua)

Attachments
Move include of sys/param.h before sys/module.h (544 bytes, patch)
2021-12-11 07:15 UTC, Tomoaki AOKI 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2021-12-11 07:15:18 UTC 
Created attachment 230038 [details]
Move include of sys/param.h before sys/module.h

On src main after git: df38ada2931f, sys/module.h SHALL be included AFTER sys/param.h.
Attached patch moves sys/param.h just before sys/modules.h to fix build.
At least x11/nvidia-driver is affected, too, but possibly more kmod ports are affected.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-12-21 13:12:05 UTC 
^Triage: [tags] in issue Titles are deprecated.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2021-12-21 17:31:07 UTC 
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-21 17:31:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ecb98de91f1386b34df8b86afb60424b8d51761

commit 0ecb98de91f1386b34df8b86afb60424b8d51761
Author:     Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
AuthorDate: 2021-12-21 13:13:24 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-12-21 17:29:25 +0000

    sysutils/acpi_call: fix build after src:df38ada2931f

    error: use of undeclared identifier MAXPATHLEN

    sys/module.h SHALL be included AFTER sys/param.h

    PR:     260333
    Reported by:    junchoon@dec.sakura.ne.jp
    Approved by:    gelraen.ua@gmail.com (maintainer, timeout 6 days)

 sysutils/acpi_call/files/patch-acpi__call.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Comment 4 Tomoaki AOKI 2021-12-22 08:58:38 UTC 
(In reply to Fernando Apesteguía from comment #2)

confirmed. Thanks!