Bug 260340 - databases/pgbarman incorrect configuration directory
Summary: databases/pgbarman incorrect configuration directory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-11 13:53 UTC by Ivan
Modified: 2021-12-17 13:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (matthew)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2021-12-11 13:53:40 UTC
I've installed pgbarman and noticed some minor issues in package:

The port creates incorrect configuration directory /usr/local/etc/py38-barman
Barman doesn't look into it, it expects one of the

        '~/.barman.conf',
        '%%PREFIX%%/etc/barman.conf',
        '%%PREFIX%%/etc/barman/barman.conf',


abishai@barman:~ % pkg info -l pgbarman |grep conf
	/usr/local/etc/py38-barman/barman.conf.sample

Probably, logging directory, suggested in sample file should be created too.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-12-17 13:51:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73e9076cbb643952df24c76910e6538d597f92ef

commit 73e9076cbb643952df24c76910e6538d597f92ef
Author:     Matthew Seaman <matthew@FreeBSD.org>
AuthorDate: 2021-12-17 13:40:37 +0000
Commit:     Matthew Seaman <matthew@FreeBSD.org>
CommitDate: 2021-12-17 13:51:15 +0000

    databases/pgbarman: Update to 2.17

    Following upstream changes, switch master site to GitHub, including
    for hte pre-build PDF manual.

    Drop support for python-3.6 -- the software claims to support this
    version, but setup.py fails with an obscure error, and considering
    that python-3.6 is going out of support at the end of this month, I
    could not justify the time to develop a compatibility fix.

    Drop the USE_PYTHON 'optsuffix' flag in favour of an explicit
    PKGNAMESUFFIX

    As reported in PR 260340, appending the python version to the barman
    ${ETCDIR} doesn't make sense.  Fix this by dropping the USE_PYTHON
    'concurrent' flag, which doesn't really make sense for end-user
    software rather than library modules. (1)

    PR:             260340 (1)
    Reported by:    bsd at abinet.ru

 databases/pgbarman/Makefile                     | 37 ++++++++-------
 databases/pgbarman/distinfo                     | 10 ++--
 databases/pgbarman/files/patch-barman_config.py | 16 +++----
 databases/pgbarman/files/patch-doc_barman.5     | 62 ++++++++++++-------------
 databases/pgbarman/files/patch-setup.py         | 37 ++++++---------
 5 files changed, 80 insertions(+), 82 deletions(-)
Comment 2 Matthew Seaman freebsd_committer freebsd_triage 2021-12-17 13:57:02 UTC
Fix committed. Thanks for the report!