Bug 260563 - games/wargus update to 3.1.2
Summary: games/wargus update to 3.1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-20 08:08 UTC by Alastair Hogge
Modified: 2022-02-25 19:13 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
wargus-3.1.2.patch (26.54 KB, patch)
2021-12-20 08:08 UTC, Alastair Hogge 		no flags Details | Diff
wargus-3.1.2.patch (26.67 KB, patch)
2021-12-20 13:54 UTC, Alastair Hogge 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2021-12-20 08:08:17 UTC 
Created attachment 230264 [details]
wargus-3.1.2.patch

Update Wargus to 3.1.2; build tested with poudriere only.
Comment 1 Alastair Hogge 2021-12-20 13:54:11 UTC 
Created attachment 230270 [details]
wargus-3.1.2.patch
Comment 2 Alastair Hogge 2021-12-20 13:56:05 UTC 
Tested with version 2.02-GOG and original DOS expansion.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-21 20:00:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f1f5d15bd9b6c7726c67de976712c19c53ede0e5

commit f1f5d15bd9b6c7726c67de976712c19c53ede0e5
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2021-12-20 17:44:00 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2021-12-21 19:57:55 +0000

    games/wargus: update to 3.1.2

    PR:             260563
    Submitted by:   agh@riseup.net

 games/wargus/Makefile             | 20 ++++++++++----------
 games/wargus/distinfo             |  6 +++---
 games/wargus/files/pkg-message.in | 32 ++++++++++----------------------
 games/wargus/pkg-descr            | 22 +++++++++++-----------
 games/wargus/pkg-plist            |  8 +++-----
 5 files changed, 37 insertions(+), 51 deletions(-)
Comment 4 Alastair Hogge 2021-12-22 07:58:54 UTC 
Thank for committing this, however, I created a separate port for StormLib because I was under the impression that ports should prefer external libraries over internal libraries with a package.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2021-12-23 15:18:57 UTC 
> I created a separate port for StormLib

Sorry, I've missed it. Will add the port and support for it in wargus now.

> I was under the impression that ports should prefer external libraries over internal libraries with a package.

That's absolutely correct, I'd even use "must" here.
However when WITH_STORMLIB=OFF, no bundled stormlib is built in wargus. Not sure what's it needed for, I've successfully playtested it without stormlib support, and even video support was there.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-02-25 19:13:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=601bb414d25aaf9803f1bc8ad380ea218218f78f

commit 601bb414d25aaf9803f1bc8ad380ea218218f78f
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2021-12-24 09:26:39 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-02-25 19:12:28 +0000

    games/wargus: add stormlib support

    PR:             260561, 260563
    Submitted by:   agh@riseup.net

 games/wargus/Makefile | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)