Bug 260611 - mount_nfs(8) references non-existent -o retransmit option
Summary: mount_nfs(8) references non-existent -o retransmit option
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL: https://github.com/freebsd/freebsd-sr...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2021-12-22 14:20 UTC by Jason W. Bacon
Modified: 2023-10-08 14:00 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2021-12-22 14:20:20 UTC
Man page line in question:

-t      Same as -o retransmit=⟨value⟩

Should this read "-o timeout=(value)"?
Comment 1 Pau Amma 2021-12-26 03:59:32 UTC
Likely should, since -o retrans= is -x.
Comment 2 Benedict Reuschling freebsd_committer freebsd_triage 2023-10-06 14:49:17 UTC
Rick, can you confirm/comment on this?
Comment 3 Rick Macklem freebsd_committer freebsd_triage 2023-10-07 01:18:49 UTC
Don't know. You would have to find an old man page (pre-nmount)
that describes what "-t" meant way back when.

The code in mount_nfs.c deprecates "-t" and says that "timeout=<N>"
should be used instead.

However, "timeout=<N>" is almost useless now, since it refers to
the initial timeout for NFS over UDP, which is almost never used
any more.

I'd suggest indicating "deprecated" next to "-t" and leave it
at that.

rick
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-10-08 13:58:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3ddd961db1ce8d9285e4d630bf6bfd5b99042a03

commit 3ddd961db1ce8d9285e4d630bf6bfd5b99042a03
Author:     Benedict Reuschling <bcr@FreeBSD.org>
AuthorDate: 2023-10-08 13:47:24 +0000
Commit:     Benedict Reuschling <bcr@FreeBSD.org>
CommitDate: 2023-10-08 13:57:47 +0000

    mount_nfs(8): Indicate that the -t option is deprecated

    In mount_nfs.c the -t option is deprecated and advises to use
    timeout=<N> instead. However, since that refers to NFS over UDP, which
    is not used nowadays, mark this option as deprecated in the man page.

    PR:             260611
    Suggested by:   rmacklem

 sbin/mount_nfs/mount_nfs.8 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Benedict Reuschling freebsd_committer freebsd_triage 2023-10-08 14:00:49 UTC
Thank you for your comments, Rick. I've committed a fix based on them.
Thanks to you, jwb@, for sending this PR. I'm closing it.