Bug 260698 - science/jmol: set JAVA_VERSION to 8
Summary: science/jmol: set JAVA_VERSION to 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://sourceforge.net/p/jmol/bugs/622/
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-26 12:11 UTC by Benjamin Takacs
Modified: 2021-12-26 16:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
nimaje+fbz: merge-quarterly?

Attachments
science/jmol: set JAVA_VERSION to 8 (499 bytes, patch)
2021-12-26 12:11 UTC, Benjamin Takacs 		nimaje+fbz: maintainer-approval? (yuri)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Takacs 2021-12-26 12:11:17 UTC 
Created attachment 230419 [details]
science/jmol: set JAVA_VERSION to 8

As jmol uses sun.audio[1] which got removed with openjdk9[0] it only supports java until version 8.

It will just fail to build if the default verison of java is set to something higher.

So the port should set JAVA_VERSION to 8.

Requesting merge-quaterly as this is a build fix.

QA:
  * portlint no new issues

[0]: https://bugs.openjdk.java.net/browse/JDK-8050465
[1]: https://sourceforge.net/p/jmol/bugs/608/
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-12-26 16:12:46 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-26 16:12:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5bc0aca655e62d40285d4f72e1be34dea9c61ceb

commit 5bc0aca655e62d40285d4f72e1be34dea9c61ceb
Author:     Benjamin Takacs <nimaje+fbz@bureaucracy.de>
AuthorDate: 2021-12-26 16:10:02 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-12-26 16:12:32 +0000

    science/jmol: Set JAVA_VERSION to 8

    Currently Jmol uses sun.audio that was removed in openjdk9.

    PR:             260698

 science/jmol/Makefile | 2 ++
 1 file changed, 2 insertions(+)