Created attachment 230632 [details] git diff 3.0.1 -> 3.0.3 Updates current 3.0.1 to upstream 3.0.3: https://github.com/dankamongmen/notcurses/releases/tag/v3.0.2 https://github.com/dankamongmen/notcurses/releases/tag/v3.0.3 Adds new binary `tfman`. Adds new -ffi library (no static version built).
Hi Nick, Thanks for the patch. Unfortunately, on Poudriere I get ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: man/man1/tfman.1.gz ===> Error: Plist issues found. Could you please check why tfman.1.gz is not installed? And more importantly, please do not use USES=ncurses:port anymore. USES=ncurses is sufficient now, see Mk/Uses/ncurses.mk. Otherwise systems with ncurses in base will get problems ;)
(In reply to Rainer Hurling from comment #1) thanks for the heads-up. i'll make both necessary changes.
ok, the reason tfman.1 isn't being installed is that it wasn't being included in the -doc- package. i've remedied this upstream; the most practical way to deal with it IMHO is to just drop it from the install set for this go-round. it'll be installed with the next version. i'm making the requested ncurses change now.
Created attachment 230646 [details] git diff 3.0.1 -> 3.0.3 Updated to drop tfman.1 from plist, and stop uses ncurses:port.
PTAL. I believe both issues have been rectified.
Created attachment 230673 [details] git diff 3.0.1 -> 3.0.3, v2 Thanks Nick, for the updated patch. The build of ncurses now behaves well under CURRENT and the missing tfman.1 does not stop the installation anymore :) But, I'm very sorry, this doesn't seem to work for 13.0 and 12.3: Your port explicitly asks for ncursew and tinfo >= 6.1 in CMakeLists.txt. Other than said, all FreeBSD versions 12.3, 13.0 and 14.0 have ncurses in the base. The ncurses versions have been >= 6.1 since 1300079 [1], but have only been split since 1400035 [1]. [1] https://docs.freebsd.org/en/books/porters-handbook/versions/ So I would like to propose a workaround, as in the new attached patch, which uses the port devel/ncurses when FreeBSD < 1400035 :) BTW: I tried your test target with 'make test' and it does not work as expected for me.
(In reply to Rainer Hurling from comment #6) what happened with "make test"? if you'd like, file a bug either here or on the upstream project, and i'll ride it down. taking a look at your counterpatch now -- thanks for the effort!
Comment on attachment 230673 [details] git diff 3.0.1 -> 3.0.3, v2 looks good to me, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=82ab268ef0ae61065151c3e444242879ec1080a4 commit 82ab268ef0ae61065151c3e444242879ec1080a4 Author: Nick Black <nickblack@linux.com> AuthorDate: 2022-01-04 05:56:09 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2022-01-04 06:01:37 +0000 devel/notcurses: Update to 3.0.3 Add a check to test for splitted ncurses in base. Changelog: https://github.com/dankamongmen/notcurses/releases/tag/v3.0.3 PR: 260887 devel/notcurses/Makefile | 14 +++++++++++--- devel/notcurses/distinfo | 10 +++++----- devel/notcurses/pkg-plist | 5 +++++ 3 files changed, 21 insertions(+), 8 deletions(-)
Committed, thanks :)