Bug 261061 - audio/wavplay: builds fine on aarch64
Summary: audio/wavplay: builds fine on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-09 14:01 UTC by Ronald Klop
Modified: 2022-01-13 13:11 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
git diff in audio/wavplay (428 bytes, patch)
2022-01-09 14:01 UTC, Ronald Klop 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop 2022-01-09 14:01:44 UTC 
Created attachment 230844 [details]
git diff in audio/wavplay

- enable on aarch64
- compile tested on aarch64
- make stage-qa ok
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2022-01-12 11:02:32 UTC 
Please confirm that it works. The reason for ONLY_FOR_ARCHS wes that it doesn't play sound correctly. I need to state it explicitly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-12 12:51:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74615207da3d4e9b707ef5713256456bcd19d6c3

commit 74615207da3d4e9b707ef5713256456bcd19d6c3
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-01-12 11:02:38 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-01-12 12:44:23 +0000

    audio/wavplay: fix ONLY_FOR_ARCHS

    - Remove powerpc* from ONLY_FOR_ARCHS, which were incorrectly added
      on a sole basis that the port builds. It needs to be runtested.
    - Add ONLY_FOR_ARCHS_REASON to prevent such mistake in future.

    PR:             261061

 audio/wavplay/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Ronald Klop 2022-01-13 10:48:07 UTC 
(In reply to Dmitry Marakasov from comment #1)
I just played https://www2.cs.uic.edu/~i101/SoundFiles/CantinaBand60.wav over an USB audio device on my RPI4.

$ wavplay /tmp/CantinaBand60.wav 
Pathname:       /tmp/CantinaBand60.wav
Device:         /dev/audio
Sampling Rate:  22050 Hz
Mode:           Mono
Samples:        1323000
Bits:           16

$ uname -a
FreeBSD rpi4 14.0-CURRENT FreeBSD 14.0-CURRENT #19 main-c72e914cf1: Wed Jan 12 03:34:04 CET 2022     ronald@rpi4:/home/ronald/dev/obj/home/ronald/dev/freebsd/arm64.aarch64/sys/GENERIC-NODEBUG  arm64
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-13 13:11:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5bd3f9f51c8e382c1a2a4fdd8557763e68c78e85

commit 5bd3f9f51c8e382c1a2a4fdd8557763e68c78e85
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-01-13 13:07:48 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-01-13 13:08:46 +0000

    audio/wavplay: allow on aarch64

    Confirmed to work correctly;
    Also simplify ONLY_FOR_ARCHS_REASON as the problems may not only
    be related to endianess.

    PR:             261061
    Submitted by:   ronald-lists@klop.ws

 audio/wavplay/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)