Bug 261193 - sysutils/am-utils /etc/rc: WARNING: $amd_enable is not set properly - see rc.conf(5).
Summary: sysutils/am-utils /etc/rc: WARNING: $amd_enable is not set properly - see rc....
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL: https://cgit.freebsd.org/ports/tree/s...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-14 11:15 UTC by Graham Perrin
Modified: 2022-01-15 23:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2022-01-14 11:15:10 UTC 
files/amd.in

<https://forums.freebsd.org/posts/551178> observes: 

> It's missing a default for _enable, which should be set to NO.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-01-14 15:58:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3920c5dda033a80a1bd0776bddac292d65d8cac2

commit 3920c5dda033a80a1bd0776bddac292d65d8cac2
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-14 15:07:26 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-14 15:57:15 +0000

    sysutils/am-utils: Default amd_enable

    Fix WARNING: $amd_enable is not set properly

    PR:             261193
    Reported by:    Graham Perrin <grahamperrin@gmail.com>
    MFH:            2022Q1

 sysutils/am-utils/Makefile     | 2 +-
 sysutils/am-utils/files/amd.in | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2022-01-14 16:12:57 UTC 
Thanks for the bug report. Fixed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-14 16:16:21 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=840cce8436dbbb81d848852292ae4a1e66d856db

commit 840cce8436dbbb81d848852292ae4a1e66d856db
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-14 15:07:26 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-14 16:14:41 +0000

    sysutils/am-utils: Default amd_enable

    Fix WARNING: $amd_enable is not set properly

    PR:             261193
    Reported by:    Graham Perrin <grahamperrin@gmail.com>

    (cherry picked from commit 3920c5dda033a80a1bd0776bddac292d65d8cac2)

 sysutils/am-utils/Makefile     | 2 +-
 sysutils/am-utils/files/amd.in | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-14 18:12:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0d2c9509e639b4204f4a336ae5cba12a995b829d

commit 0d2c9509e639b4204f4a336ae5cba12a995b829d
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-14 18:08:51 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-14 18:10:44 +0000

    sysutils/am-utils: Fix amd_enable

    Fix cut & paste oversight.

    PR:             261193
    Fixes:          3920c5dda033a80a1bd0776bddac292d65d8cac2
    Pointy hat to:  cy
    MFH:            2022Q1

 sysutils/am-utils/Makefile     | 2 +-
 sysutils/am-utils/files/amd.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-01-14 18:13:16 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f69609a997ea1284b6c5eea0ad6a9d75f3e3e94b

commit f69609a997ea1284b6c5eea0ad6a9d75f3e3e94b
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-14 18:08:51 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-14 18:12:10 +0000

    sysutils/am-utils: Fix amd_enable

    Fix cut & paste oversight.

    PR:             261193
    Fixes:          3920c5dda033a80a1bd0776bddac292d65d8cac2
    Pointy hat to:  cy

    (cherry picked from commit 0d2c9509e639b4204f4a336ae5cba12a995b829d)

 sysutils/am-utils/Makefile     | 2 +-
 sysutils/am-utils/files/amd.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 6 Graham Perrin freebsd_committer freebsd_triage 2022-01-15 23:55:42 UTC 
(In reply to Cy Schubert from comment #2)

Thanks!