Bug 261911 - Two typos in sbin/nvmecontrol
Summary: Two typos in sbin/nvmecontrol
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Kristof Provost
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-13 00:03 UTC by Andrius V
Modified: 2023-10-15 16:24 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius V 2022-02-13 00:03:15 UTC
nvmecontrol has two typos, one in comment, one in log message, see patch below:

diff --git a/sbin/nvmecontrol/logpage.c b/sbin/nvmecontrol/logpage.c
index 7daf012499a2..419b93e36c18 100644
--- a/sbin/nvmecontrol/logpage.c
+++ b/sbin/nvmecontrol/logpage.c
@@ -806,7 +806,7 @@ logpage(const struct cmd *f, int argc, char *argv[])
                NVME_CTRLR_DATA_LPA_NS_SMART_MASK;

        /*
-        * The log page attribtues indicate whether or not the controller
+        * The log page attributes indicate whether or not the controller
         * supports the SMART/Health information log page on a per
         * namespace basis.
         */
diff --git a/sbin/nvmecontrol/modules/wdc/wdc.c b/sbin/nvmecontrol/modules/wdc/wdc.c
index 050458a8812f..43f9315527ca 100644
--- a/sbin/nvmecontrol/modules/wdc/wdc.c
+++ b/sbin/nvmecontrol/modules/wdc/wdc.c
@@ -591,7 +591,7 @@ print_hgst_info_background_scan(void *buf, uint16_t subtype __unused, uint8_t re
                return;
        }
        if (code != 0) {
-               printf("Expceted code 0, found code %#x\n", code);
+               printf("Expected code 0, found code %#x\n", code);
                return;
        }
        pom = le32dec(walker);
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-08-03 11:15:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=abe10d21b4edf23ddc52f85a95ecd4cb62e5f1be

commit abe10d21b4edf23ddc52f85a95ecd4cb62e5f1be
Author:     Andrius V <vezhlys@gmail.com>
AuthorDate: 2023-08-03 10:14:19 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-08-03 10:14:19 +0000

    nvmecontrol: fix typos

    PR:             261911
    Reviewed by:    kp

 sbin/nvmecontrol/logpage.c         | 2 +-
 sbin/nvmecontrol/modules/wdc/wdc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 2 Graham Perrin 2023-10-15 13:05:39 UTC
Anything more to do here? MFC, maybe?

^Triage: 

* severity
* assign to the resolving committer.
Comment 3 Kristof Provost freebsd_committer freebsd_triage 2023-10-15 16:24:58 UTC
No MFC planned for this.