Bug 262014 - multimedia/mplayer and multimedia/mencoder: Fix incorrect library dependency linking
Summary: multimedia/mplayer and multimedia/mencoder: Fix incorrect library dependency ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-02-17 13:22 UTC by Vladimir Druzenko
Modified: 2022-02-20 15:10 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+

Attachments
fix dependencies from openjpeg 2.4 and sort out some other options (2.10 KB, patch)
2022-02-17 13:22 UTC, Vladimir Druzenko 		vvd: maintainer-approval? (riggs)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-17 13:22:34 UTC 
Created attachment 231890 [details]
fix dependencies from openjpeg 2.4 and sort out some other options

Without this patch:
Codecs: libdv ffmpeg xanim libopus libgsm speex liblzo
With:
Codecs: libvpx libdv libopencore_amrwb libopencore_amrnb ffmpeg xanim libopus libgsm speex liblzo OpenJPEG

Without patch both ports depends from graphics/openjpeg15, but linked with libopenjp2.so.7 from graphics/openjpeg.
With: depends from graphics/openjpeg and linked with libopenjp2.so.7.

mplayer options:
        AALIB          : on
        AMR_NB         : on
        AMR_WB         : on
        ASS            : on
        BLURAY         : on
        CACA           : on
        CDIO           : on
        DV             : on
        DVDNAV         : on
        ENCA           : on
        FONTCONFIG     : on
        FRIBIDI        : on
        GIF            : on
        GNUTLS         : on
        GSM            : on
        GUI            : on
        IPV6           : on
        JACK           : off
        LADSPA         : on
        LIBMNG         : on
        LIRC           : on
        LZO            : on
        NAS            : off
        NLS            : on
        OPENAL         : off
        OPENGL         : on
        OPENJPEG       : on
        OPUS           : on
        PULSEAUDIO     : off
        RTCPU          : on
        RTMP           : on
        SDL            : off
        SKINS          : on
        SMB            : on
        SNDIO          : off
        SPEEX          : on
        SVGALIB        : off
        V4L            : on
        VDPAU          : on
        VPX            : on
        X11            : on
        X11DGA         : on
        X11VM          : on
        XINERAMA       : on
        XVIDEO         : on
        XVMC           : on

mencoder options:
        AMR_NB         : on
        AMR_WB         : on
        ASS            : on
        BLURAY         : on
        CDIO           : on
        DEBUG          : off
        DV             : on
        DVDNAV         : on
        FAAC           : on
        FONTCONFIG     : on
        FRIBIDI        : on
        GIF            : on
        GNUTLS         : on
        GSM            : on
        IPV6           : on
        JACK           : off
        LADSPA         : on
        LIBMNG         : on
        LZO            : on
        MAD            : on
        NAS            : off
        NLS            : on
        OPENAL         : off
        OPENJPEG       : on
        OPUS           : on
        PULSEAUDIO     : off
        RTCPU          : on
        RTMP           : on
        SMB            : on
        SPEEX          : on
        THEORA         : on
        TWOLAME        : on
        V4L            : on
        VPX            : on
        X264           : on
        XVID           : on


Tested on 12.3 amd64: check-plist, build, install, run.
Comment 1 Dima Panov freebsd_committer freebsd_triage 2022-02-18 18:03:48 UTC 
I'll make it as part of openjpeg15 deprecation
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-02-20 10:40:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d514f4514dacf0b6fb2626545b71e8ec4a4dbe3c

commit d514f4514dacf0b6fb2626545b71e8ec4a4dbe3c
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2022-02-20 10:37:46 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-02-20 10:40:07 +0000

    multimedia/mplayer: Migrate some knobs to CONFIGURE_ENABLE

    PR:             262014
    Reported by:    VVD <vvd@unislabs.com>
    MFH:            2022Q1

 multimedia/mplayer/Makefile.optvars | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-02-20 11:19:05 UTC 
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=39da6a867124a65a9b365a2de9363cdd2978bc70

commit 39da6a867124a65a9b365a2de9363cdd2978bc70
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2022-02-20 10:37:46 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-02-20 10:44:54 +0000

    multimedia/mplayer: Migrate some knobs to CONFIGURE_ENABLE

    PR:             262014
    Reported by:    VVD <vvd@unislabs.com>
    MFH:            2022Q1

    (cherry picked from commit d514f4514dacf0b6fb2626545b71e8ec4a4dbe3c)

 multimedia/mplayer/Makefile.optvars | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2022-02-20 12:02:21 UTC 
Merged fluffy's openjpg patch in https://cgit.freebsd.org/ports/commit/?id=8d035fdefc08a65d470aeb8622bec31ce7180310
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-02-20 12:34:03 UTC 
(In reply to Thomas Zander from comment #4)
But it support openjpeg2 - why we keep dependency from openjpeg15?
Comment 6 Dima Panov freebsd_committer freebsd_triage 2022-02-20 14:10:45 UTC 
(In reply to VVD from comment #5)
Switched to openjpeg2 in 7beae5bb0fa6 and mfhed.
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2022-02-20 15:10:15 UTC 
(In reply to Dima Panov from comment #6)

Thanks!