Bug 262086 - usr.bin.diff.diff_test.functionname fails
Summary: usr.bin.diff.diff_test.functionname fails
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Tom Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-21 07:23 UTC by Li-Wen Hsu
Modified: 2022-03-01 21:39 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2022-02-21 07:23:54 UTC
Not sure if this is due to changes added along with test test case, or it discovers a previous bug:

https://ci.freebsd.org/job/FreeBSD-main-amd64-test/20686/changes

https://ci.freebsd.org/job/FreeBSD-main-amd64-test/20686/testReport/junit/usr.bin.diff/diff_test/functionname/
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-02-21 08:33:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=85eeb6ea62d45c5df893a16b87969bd7313a3dbb

commit 85eeb6ea62d45c5df893a16b87969bd7313a3dbb
Author:     Li-Wen Hsu <lwhsu@FreeBSD.org>
AuthorDate: 2022-02-21 08:31:43 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-02-21 08:31:43 +0000

    Temporarily skip usr.bin.diff.diff_test.functionname in CI

    PR:             262086
    Sponsored by:   The FreeBSD Foundation

 usr.bin/diff/tests/diff_test.sh | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-01 13:28:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4be7d087c2b566f4910683836be279d55c1a81c6

commit 4be7d087c2b566f4910683836be279d55c1a81c6
Author:     Tom Jones <thj@FreeBSD.org>
AuthorDate: 2022-03-01 13:23:25 +0000
Commit:     Tom Jones <thj@FreeBSD.org>
CommitDate: 2022-03-01 13:27:21 +0000

    diff: Use start of change when searching for function

    Use the start of change when searching for a function rather than the
    start of the context. In short functions if this could result in search
    for the function name starting from before the function definition.

    PR:             262086
    Reviewed by:    bapt, mckusick, mhorne
    Sponsored by:   Klara Inc.
    Differential Revision:  https://reviews.freebsd.org/D34328

 usr.bin/diff/diffreg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-01 21:39:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=adce4585ca56638801d12790c8f7fcb30e7408d0

commit adce4585ca56638801d12790c8f7fcb30e7408d0
Author:     Li-Wen Hsu <lwhsu@FreeBSD.org>
AuthorDate: 2022-03-01 21:37:25 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-03-01 21:37:25 +0000

    Revert "Temporarily skip usr.bin.diff.diff_test.functionname in CI"

    This reverts commit 85eeb6ea62d45c5df893a16b87969bd7313a3dbb.

    The issue has been fixed by 4be7d087c2b566f4910683836be279d55c1a81c6.

    PR:             262086

 usr.bin/diff/tests/diff_test.sh | 4 ----
 1 file changed, 4 deletions(-)