Hello All, Found something of a nasty typo in the following 3 branches (all AMD64, possibly more...) 13.0-RELEASE, 13.0-STABLE and 14-CURRENT (still present, just checked 5 mins ago) The file involved is located at /usr/include/dev/nvme/nvme.h The issue can be found around line 1284-ish, specifically: NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS = 0x0c, To the most OCD-afflicted of us, will find the obvious typo, that NAMESPACE is *not* spelled with a "V". The issue revealed itself to me while attempting to build /usr/ports/sysutils/bhyve+/ on a 14-CURRENT machine and complaints about "NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS" caused a break in the port build. The fix is obviously simple, replace NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS with NVME_LOG_ASYMMETRIC_NAMESPACE_ACCESS, note the word NAMESPACE is spelled with a "C". Hope this helps the community.
Committed (c2318cf80a9e - main - nvme: fix spelling of Namespace) a fix for this to current and will MFC in a couple of days to stable/13 commit: https://cgit.FreeBSD.org/src/commit/?id=c2318cf80a9edf5bfcd5ed20037c8d0b80a78d69 review: https://reviews.freebsd.org/D34330
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=7de3a3e919ecaec466d5284eb17503d499beced1 commit 7de3a3e919ecaec466d5284eb17503d499beced1 Author: Chuck Tuffli <chuck@FreeBSD.org> AuthorDate: 2022-02-21 18:34:46 +0000 Commit: Chuck Tuffli <chuck@FreeBSD.org> CommitDate: 2022-02-28 01:59:31 +0000 nvme: fix spelling of Namespace Fix spelling of a macro definition. PR: 262141 (cherry picked from commit c2318cf80a9edf5bfcd5ed20037c8d0b80a78d69) sbin/nvmecontrol/logpage.c | 2 +- sys/dev/nvme/nvme.h | 2 +- usr.sbin/bhyve/pci_nvme.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)