Bug 262338 - www/gitlab-ce: start redis before gitlab-ce
Summary: www/gitlab-ce: start redis before gitlab-ce
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-04 11:57 UTC by Marián Černý
Modified: 2022-03-09 10:11 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mfechner)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marián Černý 2022-03-04 11:57:09 UTC 
After upgrading my system from FreeBSD 12.2 to 12.3 I noticed the following error:

    The GitLab Sidekiq job dispatcher is not running.

    sidekiq.log: Error connecting to Redis on /var/run/redis/redis.sock (Errno::ENOENT)

The error was caused by starting gitlab-ce before redis server. Probably the rcorder has changed for my gitlab jail instance after upgrade to FreeBSD 12.3.

I have fixed the problem by adding `redis` to REQUIRE: in the rc.d startup script:

    # REQUIRE: LOGIN redis

Please consider adding `redis` to the REQUIRE: block in /usr/local/etc/rc.d/gitlab for all users. Thanks.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2022-03-05 10:37:07 UTC 
Thanks a lot, I will include this into the next upgrade of the port.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-09 10:10:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8be9a4007adac910482efb6282294ad0a536873

commit d8be9a4007adac910482efb6282294ad0a536873
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2022-03-05 10:35:40 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2022-03-09 10:07:54 +0000

    www/gitlab-ce: depend on redis in startup script

    This ensures that gitlab is not started before redis is available.
    PR:             262338
    Reported by:    majo-bugs.freebsd.org@cerny.sk

 www/gitlab-ce/files/gitlab.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2022-03-09 10:11:12 UTC 
Should be fixed now, thanks for report!