Bug 262417 - armv7 build fails for ARMADAXP
Summary: armv7 build fails for ARMADAXP
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-08 11:13 UTC by Mina Galić
Modified: 2022-10-02 04:30 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mina Galić freebsd_triage 2022-03-08 11:13:59 UTC
# Meta data file /usr/obj/poudriere/jails/14-current-armv7/usr/src/arm.armv7/sys/ARMADAXP/ofw_cpu.o.meta
CMD cc -target armv7-gnueabihf-freebsd14.0 --sysroot=/usr/obj/poudriere/jails/14-current-armv7/usr/src/arm.armv7/tmp -B/usr/obj/poudriere/jails/14-current-armv7/usr/src/arm.armv7/tmp/usr/bin -c -O2 -pipe  -fno-strict-aliasing  -g -nostdinc  -I. -I/poudriere/jails/14-current-armv7/usr/src/sys -I/poudriere/jails/14-current-armv7/usr/src/sys/contrib/ck/include -I/poudriere/jails/14-current-armv7/usr/src/sys/contrib/libfdt -I/poudriere/jails/14-current-armv7/usr/src/sys/contrib/device-tree/include -I$/dts/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common   -march=armv7a -DLINUX_DTS_VERSION=\""5.13"\" -funwind-tables -fdebug-prefix-map=./machine=/poudriere/jails/14-current-armv7/usr/src/sys/arm/include -ffreestanding -fwrapv -fstack-protector -Wall -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-error=unused-but-set-variable -Wno-format-zero-length   -mfpu=none  -std=iso9899:1999 -Werror /poudriere/jails/14-current-armv7/usr/src/sys/dev/ofw/ofw_cpu.c
CMD ctfconvert -L VERSION -g ofw_cpu.o
CWD /usr/obj/poudriere/jails/14-current-armv7/usr/src/arm.armv7/sys/ARMADAXP
TARGET ofw_cpu.o
OODATE /poudriere/jails/14-current-armv7/usr/src/sys/dev/ofw/ofw_cpu.c offset.inc assym.inc vnode_if.h fdt_static_dtb.h miidevs.h usbdevs.h usbdevs_data.h rpctlscd.h rpctlssd.h card_if.h power_if.h fb_if.h iicbus_if.h ofw_iicbus_if.h mdio_if.h miibus_if.h mmcbr_if.h mmcbus_if.h mvs_if.h ofw_bus_if.h ofw_if.h pci_if.h pci_iov_if.h pcib_if.h uart_if.h usb_if.h g_part_if.h isa_if.h bus_if.h clock_if.h cpufreq_if.h device_if.h linker_if.h serdev_if.h cryptodev_if.h platform_if.h msi_if.h pic_if.h opt_global.h machine
-- command output --
In file included from /poudriere/jails/14-current-armv7/usr/src/sys/dev/ofw/ofw_cpu.c:49:
/poudriere/jails/14-current-armv7/usr/src/sys/dev/extres/clk/clk.h:37:10: fatal error: 'clknode_if.h' file not found
#include "clknode_if.h"
         ^~~~~~~~~~~~~~
1 error generated.

*** Error code 1

it appears that other armv7 KERNCONFs also need this commit: f34560385c730c8b1db4f46a9c711a60511864bf
Comment 1 Warner Losh freebsd_committer freebsd_triage 2022-03-08 18:56:59 UTC
I have a fix for this in my queue...
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-05 04:33:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=04bb568fdcd40b201395df198e3498b55377b78b

commit 04bb568fdcd40b201395df198e3498b55377b78b
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-03-08 17:52:31 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-04-05 04:29:02 +0000

    ARMADAXP: Add extres pseudo devices to some kernel

    Add extres and related pseudo devices to allow this to compile.

    Sponsored by:           Netflix
    PR:                     262417

 sys/arm/conf/ARMADAXP | 11 +++++++++++
 1 file changed, 11 insertions(+)
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2022-04-18 19:37:20 UTC
Verified that this is fixed now.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-02 04:30:50 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5f1346a9f636475ee275d7aea44d48ce453a60f1

commit 5f1346a9f636475ee275d7aea44d48ce453a60f1
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-07-08 17:53:28 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-10-02 04:25:50 +0000

    ARMADAXP: Add extres pseudo devices to some kernel

    Add extres and related pseudo devices to allow this to compile.

    Sponsored by:           Netflix
    PR:                     262417

    (cherry picked from commit 04bb568fdcd40b201395df198e3498b55377b78b)

 sys/arm/conf/ARMADAXP | 11 +++++++++++
 1 file changed, 11 insertions(+)