Bug 262616 - audio/carla: does not fully respect LOCALBASE
Summary: audio/carla: does not fully respect LOCALBASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-17 12:09 UTC by Ellenor Bjornsdottir
Modified: 2022-03-17 15:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
patch -p1 format - Difference between upstream audio/carla/Makefile and my copy (441 bytes, patch)
2022-03-17 12:09 UTC, Ellenor Bjornsdottir
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ellenor Bjornsdottir 2022-03-17 12:09:40 UTC
Created attachment 232512 [details]
patch -p1 format - Difference between upstream audio/carla/Makefile and my copy

audio/carla does not appear to use a configure script. Instead, it directly invokes GNU Make. On my system, I have LOCALBASE set other than the default of /usr/local, meaning that this port, which had PREFIX := /usr/local set in its Makefile (rendering this patch unnecessary when LOCALBASE is the default of /usr/local), did not install correctly because the files which something in the system was looking for were under $DESTDIR/usr/local, not $DESTDIR$LOCALBASE. Some documentation in the source tree of audio/carla says that distributions can override this by adding PREFIX=theirlocalbase to gmake's invocation. I attach a diff which I've implemented on my local ports tree which heeds that advice and appears to make audio/carla build and install correctly on my system.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-03-17 15:24:45 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-17 15:24:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4588f14d094e34ed664627dadc621044fbecabc9

commit 4588f14d094e34ed664627dadc621044fbecabc9
Author:     Ellenor Bjornsdottir <large.hadron.collider@gmx.com>
AuthorDate: 2022-03-17 15:21:37 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-03-17 15:24:30 +0000

    audio/carla: Respect LOCALBASE

    PR:             262616

 audio/carla/Makefile | 1 +
 1 file changed, 1 insertion(+)