Bug 262646 - New bullet-point to 6.1 microbenchmaring
Summary: New bullet-point to 6.1 microbenchmaring
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-doc (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-18 12:48 UTC by Poul-Henning Kamp
Modified: 2024-05-29 19:26 UTC (History)
3 users (show)

See Also:

Attachments
patch for developer handbook (1.29 KB, patch)
2024-02-17 12:58 UTC, Chris Moerz 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Poul-Henning Kamp freebsd_committer freebsd_triage 2022-03-18 12:48:48 UTC 
Please add:

* Disable "Turbo-modes".  Turbo-mode make the clock frequency explicitly depend on the environment.  This means that benchmark runs on 100% identical code, may depend on time of day, coffee vs soda or even how many other people are in the office.
Comment 1 Pau Amma 2022-03-19 00:42:56 UTC 
Is this about documentation/content/en/books/developers-handbook/testing/_index.adoc in the Developer's Handbook?
Comment 2 Chris Moerz 2024-02-17 12:58:35 UTC 
Created attachment 248531 [details]
patch for developer handbook

If I read this right, this is what was meant? Not sure, if it wouldn't help to improve the reasoning or link to supporting documentation that outlines why turbo mode does that?

When I'm thinking of turbo mode, I'm thinking 286, 386 computers with turbo buttons on the outside?
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-29 19:25:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=fd25efa62a92d2abdeec0493fba2d30a68ce43db

commit fd25efa62a92d2abdeec0493fba2d30a68ce43db
Author:     Benedict Reuschling <bcr@FreeBSD.org>
AuthorDate: 2024-05-29 19:21:31 +0000
Commit:     Benedict Reuschling <bcr@FreeBSD.org>
CommitDate: 2024-05-29 19:21:31 +0000

    Add bullet-point about disabling "Turbo-modes"

    Elaborate on this point a bit how and why they interfere with
    microbenchmarking.

    PR:     262646

 .../content/en/books/developers-handbook/testing/_index.adoc          | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 4 Benedict Reuschling freebsd_committer freebsd_triage 2024-05-29 19:26:16 UTC 
Patch (plus your additional comments) committed. Thanks for the addition to the developers-handbook.