Created attachment 232556 [details] Support of dav1d 1.0.0 Details are at upstream issue tracker: https://sourceforge.net/p/xine/tickets/11/ Tested on 12.3-p3 amd64.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3b3b0fa358409a78150119c36d8cd236de7f91fc commit 3b3b0fa358409a78150119c36d8cd236de7f91fc Author: VVD <vvd@unislabs.com> AuthorDate: 2022-03-18 17:36:44 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2022-03-18 20:44:49 +0000 multimedia/libxine: unbreak DAV1D=on after 3468f1957cf2 dav1d.c:547:12: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_frame_threads = (ncpu > 8) ? 4 : (ncpu < 2) ? 1 : ncpu/2; ~~~~~~~~ ^ dav1d.c:548:12: error: no member named 'n_tile_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ dav1d.c:548:52: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ dav1d.c:548:52: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ /usr/include/sys/param.h:306:34: note: expanded from macro 'MAX' #define MAX(a,b) (((a)>(b))?(a):(b)) ^ dav1d.c:551:22: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_frame_threads, settings.n_tile_threads); ~~~~~~~~ ^ dav1d.c:551:48: error: no member named 'n_tile_threads' in 'struct Dav1dSettings' settings.n_frame_threads, settings.n_tile_threads); ~~~~~~~~ ^ ../../include/xine/xineutils.h:687:40: note: expanded from macro 'xprintf' xine_log(xine, XINE_LOG_TRACE, __VA_ARGS__); \ ^~~~~~~~~~~ PR: 262651 multimedia/libxine/files/patch-dav1d-1.0 (new) | 47 ++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
A commit in branch 2022Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c65853b5ceaf2cc33238732070849b0cf14b9f77 commit c65853b5ceaf2cc33238732070849b0cf14b9f77 Author: VVD <vvd@unislabs.com> AuthorDate: 2022-03-18 17:36:44 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2022-03-18 20:47:43 +0000 multimedia/libxine: unbreak DAV1D=on after 3468f1957cf2 dav1d.c:547:12: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_frame_threads = (ncpu > 8) ? 4 : (ncpu < 2) ? 1 : ncpu/2; ~~~~~~~~ ^ dav1d.c:548:12: error: no member named 'n_tile_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ dav1d.c:548:52: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ dav1d.c:548:52: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_tile_threads = MAX(1, ncpu - settings.n_frame_threads + 1); ~~~~~~~~ ^ /usr/include/sys/param.h:306:34: note: expanded from macro 'MAX' #define MAX(a,b) (((a)>(b))?(a):(b)) ^ dav1d.c:551:22: error: no member named 'n_frame_threads' in 'struct Dav1dSettings' settings.n_frame_threads, settings.n_tile_threads); ~~~~~~~~ ^ dav1d.c:551:48: error: no member named 'n_tile_threads' in 'struct Dav1dSettings' settings.n_frame_threads, settings.n_tile_threads); ~~~~~~~~ ^ ../../include/xine/xineutils.h:687:40: note: expanded from macro 'xprintf' xine_log(xine, XINE_LOG_TRACE, __VA_ARGS__); \ ^~~~~~~~~~~ PR: 262651 (cherry picked from commit 3b3b0fa358409a78150119c36d8cd236de7f91fc) multimedia/libxine/files/patch-dav1d-1.0 (new) | 47 ++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
Thanks for the fix and upstream report. I didn't notice libxine has DAV1D disabled by default unlike other ports.
(In reply to Jan Beich from comment #3) Just for information. Upstream commit this patch: https://sourceforge.net/p/xine/xine-lib-1.2/ci/97248a71021428baa49e2b2af34f566a3257452a/