Bug 262672 - devel/subversion does not build with db18
Summary: devel/subversion does not build with db18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-19 16:41 UTC by rshare
Modified: 2022-04-22 09:46 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lev)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rshare 2022-03-19 16:41:39 UTC 
If only db18 is installed, subversion does not build.
The same change as in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202505 also solves this issue if -a "$${BDB_VERSION}" != "18" is added.
Comment 1 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-03-21 11:19:04 UTC 
I'm not sure, that subversion supports db18. Officially only 4.x is supported, and db18 is much older.

Also, BDB support is deprecated and discouraged at all by new versions of Subversion.

Do we need this hack-ish support for db18? Did you try to run all test suite with db18, or only build was tested?
Comment 2 Oleg Sidorkin 2022-04-01 10:29:54 UTC 
db18 is 18.1.40 and looks much newer than db4
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-04-01 13:43:50 UTC 
(In reply to Oleg Sidorkin from comment #2)
Oh, I've thought about old db18 which is really db 1.8 :)
I'll apply this patch this weekend, thank you!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-13 14:09:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3eb02cd1ee47155c83cc87a2eab5132beedac3b

commit b3eb02cd1ee47155c83cc87a2eab5132beedac3b
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2022-04-13 14:06:45 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2022-04-13 14:09:04 +0000

    devel/subversion: Update to latest version 1.14.2, fix two CVEs

      Update subversion to 1.14.2. This fix two CVEs.

      Also, allows build with database/db18.

    PR:             262672
    Security:       CVE-2021-28544
    Security:       CVE-2022-24070

 devel/subversion/Makefile        | 4 ++--
 devel/subversion/Makefile.common | 2 +-
 devel/subversion/distinfo        | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 5 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-04-13 14:17:46 UTC 
Committed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-04-22 09:46:47 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=115fa564c8ce85904377fefac911340f5ba66e80

commit 115fa564c8ce85904377fefac911340f5ba66e80
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2022-04-13 14:06:45 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2022-04-22 09:46:04 +0000

    devel/subversion: Update to latest version 1.14.2, fix two CVEs

      Update subversion to 1.14.2. This fix two CVEs.

      Also, allows build with database/db18.

    PR:             262672
    Security:       CVE-2021-28544
    Security:       CVE-2022-24070
    (cherry picked from commit b3eb02cd1ee47155c83cc87a2eab5132beedac3b)

 devel/subversion/Makefile        | 4 ++--
 devel/subversion/Makefile.common | 2 +-
 devel/subversion/distinfo        | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)