Bug 263163 - games/xboard: with default of no engine installed, xboard errors out on empty -firstChessProgram in xboard.conf
Summary: games/xboard: with default of no engine installed, xboard errors out on empty...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-08 20:20 UTC by Pau Amma
Modified: 2022-07-21 15:33 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mbeis)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pau Amma 2022-04-08 20:20:37 UTC
The immediate cause seems to be in Makefile target post-patch, which includes:

        @firstEngine=`cat ${WRKSRC}/firstEngine.txt` && \
         ${REINPLACE_CMD} -e "s|\(-firstChessProgram\) .*|\1 $${firstEngine}|" ${XBOARDCONF}

"OPTIONS_DEFAULT?=       XAW" doesn't include any engine, which leaves that line empty instead of the upstream setting "-firstChessProgram fairymax".

I'm not sure whether the best fix is to make it depend on one engine by default or to have a pkg-message saying "install one manually and adjust xboard.conf to match", but I'm leaning toward the former since that's what upstream does.

Reported in #freebsd-bugs.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-07-21 15:33:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2ad5b95cc18a74c1e61519cfaa20b04c2a715b75

commit 2ad5b95cc18a74c1e61519cfaa20b04c2a715b75
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-07-21 05:36:52 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-21 15:28:52 +0000

    games/xboard: Add default engine

    With default of no engine installed, xboard errors out on empty
    -firstChessProgram in xboard.conf

    Make FAIRYMAX the default engine (as upstream does).

    PR:     263163
    Reported by:    pauamma@gundo.com

 games/xboard/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-21 15:33:44 UTC
Fixed,

Thanks!