Bug 264133 - shells/rc: Takes maintainership
Summary: shells/rc: Takes maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Helfman
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2022-05-21 19:51 UTC by Chris Hutchinson
Modified: 2022-06-09 02:11 UTC (History)
1 user (show)

See Also:

Attachments
git patch for shells/rc (649 bytes, patch)
2022-05-21 19:51 UTC, Chris Hutchinson 		no flags Details | Diff
git diff against shells/rc -- takes maintainer && adds recommendations (923 bytes, patch)
2022-06-08 16:44 UTC, Chris Hutchinson 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2022-05-21 19:51:56 UTC 
Created attachment 234090 [details]
git patch for shells/rc

My recent work with this port seems to indicate
the current maintainer is MIA. As a result. If
there's no objection I'd like to maintain this
port.
The attached patch accomplishes that.

That's it.

Thanks!

Chris
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-05-21 19:51:56 UTC 
Maintainer informed via mail
Comment 2 Chris Hutchinson 2022-06-08 16:44:06 UTC 
Created attachment 234557 [details]
git diff against shells/rc -- takes maintainer && adds recommendations

This patch is an update based upon observances by jgh@ &&
portlint. It incorporates all recommendations except the
complaint for makepatch.

1) change MAINTAINER
2) Change order of PORT/DIST in Makefile
3) (unnecessarily) remove SHA512 entry in distinfo
4) complaint against patch not made with make makepatch (ignored)
use of `make makepatch` made no changes or recommendations when
executed against the patch.

That's it.

Thanks!

Chris
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-09 02:10:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c752a1e7d236095381b4251e73e792e2b906d935

commit c752a1e7d236095381b4251e73e792e2b906d935
Author:     Jason Helfman <jgh@FreeBSD.org>
AuthorDate: 2022-06-09 02:00:49 +0000
Commit:     Jason Helfman <jgh@FreeBSD.org>
CommitDate: 2022-06-09 02:07:01 +0000

    shells/rc: set maintainer to reporter, drop unsupported checksum algorithm

    PR:     264133 (based on)
    Approved by:    maintainer-timeout (multiple)

 shells/rc/Makefile | 6 +++---
 shells/rc/distinfo | 3 +--
 2 files changed, 4 insertions(+), 5 deletions(-)
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2022-06-09 02:11:59 UTC 
Committed! Thanks for report!

-jgh