Bug 264181 - [exp-run] Identify xsockbuf's sb_mcnt/sb_ccnt usage in ports
Summary: [exp-run] Identify xsockbuf's sb_mcnt/sb_ccnt usage in ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Smirnoff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-23 18:17 UTC by Gleb Smirnoff
Modified: 2022-05-27 15:21 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
patch to apply to tested system (6.86 KB, patch)
2022-05-23 18:17 UTC, Gleb Smirnoff 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Smirnoff freebsd_committer freebsd_triage 2022-05-23 18:17:17 UTC 
Created attachment 234155 [details]
patch to apply to tested system

I'd like to check if any ports use sb_mcnt/sb_ccnt. Please report any new build failures with attached patch. Thanks!
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2022-05-26 18:53:26 UTC 
Exp-run looks fine,  I saw 0 new failure
Comment 2 Gleb Smirnoff freebsd_committer freebsd_triage 2022-05-27 04:02:24 UTC 
Thanks a lot, Antoine!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-27 15:21:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d59bc188d652dfaa06bef9963120aa54c4c68875

commit d59bc188d652dfaa06bef9963120aa54c4c68875
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2022-05-27 15:19:28 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2022-05-27 15:20:17 +0000

    sockbuf: remove unused mbuf counter and cluster counter

    With M_EXTPG mbufs these two counters already do not represent the
    reality.  As we are moving towards protocol independent socket buffers,
    which may not even use mbufs at all, the counters become less and less
    relevant.  The only userland seeing them was 'netstat -x'.

    PR:                     264181 (exp-run)
    Reviewed by:            markj
    Differential revision:  https://reviews.freebsd.org/D35334

 sys/kern/uipc_debug.c     |  2 --
 sys/kern/uipc_sockbuf.c   | 31 ++++++-------------------------
 sys/sys/sockbuf.h         |  2 --
 sys/sys/socketvar.h       |  2 --
 usr.bin/netstat/inet.c    | 13 +++----------
 usr.bin/netstat/netstat.1 |  9 ++-------
 6 files changed, 11 insertions(+), 48 deletions(-)