Bug 264277 - [sysutils/rubygem-facter] Missing dependencies
Summary: [sysutils/rubygem-facter] Missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: FreeBSD Puppet Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-27 09:07 UTC by albert.shih
Modified: 2022-08-20 03:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (puppet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description albert.shih 2022-05-27 09:07:05 UTC
The facter gem are missing 

sysutils/rubygem-sys-filesystem
textproc/rubygem-rexml

without the first facter dont't return mountpoints (as core facts) with this message (in debug mode)

[2022-05-27 10:47:01.240730 ] DEBUG Facter::Resolvers::Mountpoints - Resolving fact mountpoints, but got cannot load such file -- sys/filesystem at <internal:/usr/local/lib/ruby/site_ruby/3.0/rubygems/core_ext/kernel_require.rb>:85:in `require' 


Without the second facter don't return disk facts (also as core facts) with this message :

[2022-05-27 10:47:01.260833 ] DEBUG Facter::Resolvers::Freebsd::Geom - Resolving fact disks, but got cannot load such file -- rexml/document at <internal:/usr/local/lib/ruby/site_ruby/3.0/rubygems/core_ext/kernel_require.rb>:85:in `require' 

Regards
Comment 1 albert.shih 2022-06-15 09:09:22 UTC
Also missing dependency : rubygem-ruby-augeas otherwise unable to use augeas ressource in puppet (standard resource if I'm correct)
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2022-07-08 20:12:40 UTC
The idea is to have minimal dependencies and allow people to use puppet to install extra packages that provide extra facts if they need it only.

That being said, discoverability of these packages might not be easy.

What would you consider the best?  Having hard dependencies and resolving all that can be by default?  Providing OPTIONS to allow to opt-in for adding dependencies ?  Do you think a post-installation message listing these dependencies would be better ?

I don't really have an opinion about this, community feedback is welcome!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-20 02:33:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a082c1b64a8aca8ad6ffd4fdfb0694e6d793d60

commit 5a082c1b64a8aca8ad6ffd4fdfb0694e6d793d60
Author:     Romain Tartière <romain@FreeBSD.org>
AuthorDate: 2022-08-20 00:37:48 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2022-08-20 02:32:36 +0000

    sysutils/puppet7: Bundle core modules with Puppet

    The AIO Package vendor these modules, so also vendor them on FreeBSD.

    PR:             264277
    Reported by:    albert.shih@obspm.fr
    With hat:       puppet

 sysutils/puppet7/Makefile  |  24 ++++
 sysutils/puppet7/distinfo  |  22 +++-
 sysutils/puppet7/pkg-plist | 270 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 315 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-20 02:33:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=681e32faea72f0eff7fbac95e7d21ecfe576c829

commit 681e32faea72f0eff7fbac95e7d21ecfe576c829
Author:     Romain Tartière <romain@FreeBSD.org>
AuthorDate: 2022-08-20 00:36:26 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2022-08-20 02:32:34 +0000

    sysutils/puppet6: Bundle core modules with Puppet

    The AIO Package vendor these modules, so also vendor them on FreeBSD.

    PR:             264277
    Reported by:    albert.shih@obspm.fr
    With hat:       puppet

 sysutils/puppet6/Makefile  |  32 ++++-
 sysutils/puppet6/distinfo  |  22 +++-
 sysutils/puppet6/pkg-plist | 289 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 336 insertions(+), 7 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-20 02:33:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f3fe6a35a16f4f1350e91c41f8a246ba4e442396

commit f3fe6a35a16f4f1350e91c41f8a246ba4e442396
Author:     Romain Tartière <romain@FreeBSD.org>
AuthorDate: 2022-08-20 00:33:20 +0000
Commit:     Romain Tartière <romain@FreeBSD.org>
CommitDate: 2022-08-20 02:32:32 +0000

    sysutils/rubygem-facter: Add soft-dependencies

    Some facts are only resolved when some extra gems are installed.  Add
    them as dependecy so that we have all basic facts by default regardless
    of what is already installed on the system.

    While here, reorder the Makefile to make portlint happy.

    PR:             264277
    Reported by:    albert.shih@obspm.fr
    With hat:       puppet

 sysutils/rubygem-facter/Makefile | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)