Bug 264634 - uchcom(4) does not detect CH340K
Summary: uchcom(4) does not detect CH340K
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Hans Petter Selasky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-12 13:49 UTC by Tomoyuki Sakurai
Modified: 2022-06-20 11:13 UTC (History)
1 user (show)

See Also:

Attachments
a patch to detect CH340K (513 bytes, patch)
2022-06-12 13:49 UTC, Tomoyuki Sakurai 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoyuki Sakurai 2022-06-12 13:49:48 UTC 
Created attachment 234641 [details]
a patch to detect CH340K

uchcom(4) does not detect CH340K, which is often used in cheap ESP32 development boards. Bug #260783 added the USB ID, but does not attach the device on my CURRENT (dc484aed0a014de0fdf33d972c36413da6903a2e, May 9). the patch fixes it.

ugen0.7: <vendor 0x1a86 USB Serial> at usbus0
uchcom0 on uhub1
uchcom0: <vendor 0x1a86 USB Serial, rev 1.10/2.64, addr 6> on usbus0
uchcom0: CH341 detected
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2022-06-12 14:41:54 UTC 
Looks like a chunk was missing from the initial PR #260783  .
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-06-12 14:42:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f25a0a0f21183a52eeb4a860a88114aebec5f249

commit f25a0a0f21183a52eeb4a860a88114aebec5f249
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2022-06-12 14:40:36 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2022-06-12 14:42:03 +0000

    uchcom(4): Add new USB ID.

    PR:             260783
    PR:             264634
    MFC after:      1 week
    Sponsored by:   NVIDIA Networking

 sys/dev/usb/serial/uchcom.c | 1 +
 1 file changed, 1 insertion(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-20 11:13:25 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=0b5f08439d27ecbfa4b4c20acef64fbad66e978a

commit 0b5f08439d27ecbfa4b4c20acef64fbad66e978a
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2022-06-12 14:40:36 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2022-06-20 11:08:39 +0000

    uchcom(4): Add new USB ID.

    PR:             260783
    PR:             264634
    Sponsored by:   NVIDIA Networking

    (cherry picked from commit f25a0a0f21183a52eeb4a860a88114aebec5f249)

 sys/dev/usb/serial/uchcom.c | 1 +
 1 file changed, 1 insertion(+)