Bug 264680 - net/belle-sip: build fails if devel/antlr3 is installed
Summary: net/belle-sip: build fails if devel/antlr3 is installed
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-15 11:39 UTC by Vladimir Druzenko
Modified: 2022-06-21 12:14 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 11:39:45 UTC
net/belle-sip grab /usr/local/bin/antlr3 (from devel/antlr3 version is 3.5.2) instead required 3.4 (antlr-3.4-complete.jar in distinfo).

Part of build log with installed devel/antlr3:
===>  Building for belle-sip-1.6.3
[  2% 2/47] cd /tmp/work/usr/ports/net/belle-sip/work/.build/src && /usr/local/bin/antlr3 -make -Xmultithreaded -Xconversiontimeout 10000 -fo /tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars /tmp/work/usr/ports/net/belle-sip/work/belle-sip-1.6.3-0/src/grammars/belle_sdp.g
two-threaded DFA conversion
warning(24):  template error: context [/outputFile /parser] 1:1 could not pass through undefined attribute filterMode
warning(24):  template error: context [/outputFile /parser /genericParser /_sub165 /ruleAttributeScopeFuncMacro] 1:4 no such property or can't access: null.attributes
warning(24):  template error: context [/outputFile /parser /genericParser /_sub165 /ruleAttributeScopeFuncMacro] 1:4 no such property or can't access: null.attributes
... a lot of lines with same warnings ...
warning(24):  template error: context [/headerFile /_sub141 /ruleAttributeScopeDecl] 1:4 no such property or can't access: null.
attributes
two-threaded DFA conversion
warning(24):  template error: context [/outputFile /lexer /lexerRule /ruleDeclarations] 4:1 no such property or can't access: null.attributes
warning(24):  template error: context [/outputFile /lexer /lexerRule /ruleDeclarations] 4:1 no such property or can't access: null.attributes
... a lot of lines with same warnings ...
... cut ...
FAILED: src/CMakeFiles/bellesip.dir/grammars/belle_sdpParser.c.o 
/usr/bin/cc -DBELLESIP_EXPORTS -DHAVE_CONFIG_H -Dbellesip_EXPORTS -I/tmp/work/usr/ports/net/belle-sip/work/belle-sip-1.6.3-0/include -I/tmp/work/usr/ports/net/belle-sip/work/belle-sip-1.6.3-0/src -I/tmp/work/usr/ports/net/belle-sip/work/.build -I/tmp/work/usr/ports/net/belle-sip/work/.build/src -isystem /usr/local/include -O2 -pipe -march=core2  -fstack-protector-strong -fno-strict
-aliasing -O2 -pipe -march=core2  -fstack-protector-strong -fno-strict-aliasing -fPIC -std=gnu99  -Wall -Wuninitialized -Wno-error=deprecated-declarations -Wno-error=unknown-warning-option -Qunused-arguments -Wno-tautological-compare -Wno-builtin-requires-header -Wno-unused-function -Wno-gnu-designator -Wno-array-bounds -Wno-strict-prototypes -Wno-error=sign-compare -MD -MT src/CMakeFiles/bellesip.dir/grammars/belle_sdpParser.c.o -MF src/CMakeFiles/bellesip.dir/grammars/belle_sdpParser.c.o.d -o src/CMakeFiles/bellesip.dir/grammars/belle_sdpParser.c.o -c /tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:3696:5: error: use of undeclared identifier '_empty'
    _empty, _empty, dfa1_T4, dfa1_T8, dfa1_T13, dfa1_T17, dfa1_T10, dfa1_T8, 
    ^
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:3696:13: error: use of undeclared identifier '_empty'
    _empty, _empty, dfa1_T4, dfa1_T8, dfa1_T13, dfa1_T17, dfa1_T10, dfa1_T8, 
            ^
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:4027:5: error: use of undeclared identifier '_empty'
    _empty, _empty, dfa2_T6, dfa2_T12, dfa2_T11, dfa2_T14, dfa2_T4, dfa2_T12, 
    ^
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:4027:13: error: use of undeclared identifier '_empty'
    _empty, _empty, dfa2_T6, dfa2_T12, dfa2_T11, dfa2_T14, dfa2_T4, dfa2_T12, 
            ^
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:4358:14: error: use of undeclared identifier '_empty'
    dfa3_T8, _empty, _empty, dfa3_T6, dfa3_T0, dfa3_T13, dfa3_T17, dfa3_T11, 
             ^
/tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars/belle_sdpParser.c:4358:22: error: use of undeclared identifier '_empty'
    dfa3_T8, _empty, _empty, dfa3_T6, dfa3_T0, dfa3_T13, dfa3_T17, dfa3_T11,
... a lot of lines with same errors ...


Correct build look like:
===>  Building for belle-sip-1.6.3
[  2% 2/47] cd /tmp/work/usr/ports/net/belle-sip/work/.build/src && /usr/local/bin/java -Xmx384m -jar /tmp/work/usr/ports/net/belle-sip/work/antlr3.jar -make -Xmultithreaded -Xconversiontimeout 10000 -fo /tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars /tmp/work/usr/ports/net/belle-sip/work/belle-sip-1.6.3-0/src/grammars/belle_sdp.g
two-threaded DFA conversion
two-threaded DFA conversion
[  4% 2/47] cd /tmp/work/usr/ports/net/belle-sip/work/.build/src && /usr/local/bin/java -Xmx384m -jar /tmp/work/usr/ports/net/belle-sip/work/antlr3.jar -make -Xmultithreaded -Xconversiontimeout 10000 -fo /tmp/work/usr/ports/net/belle-sip/work/.build/src/grammars /tmp/work/usr/ports/net/belle-sip/work/belle-sip-1.6.3-0/src/grammars/belle_sip_message.g
two-threaded DFA conversion
two-threaded DFA conversion
... cut ...

Parts of:
diff -u belle_sdpParser.c.bad belle_sdpParser.c.good
@@ -3693,7 +3713,7 @@
 {
     dfa1_T18, dfa1_T11, dfa1_T11, dfa1_T9, dfa1_T1, dfa1_T12, dfa1_T5, dfa1_T19, 
     dfa1_T16, dfa1_T1, dfa1_T0, dfa1_T3, dfa1_T7, dfa1_T2, dfa1_T2, dfa1_T6, 
-    _empty, _empty, dfa1_T4, dfa1_T8, dfa1_T13, dfa1_T17, dfa1_T10, dfa1_T8, 
+    NULL, NULL, dfa1_T4, dfa1_T8, dfa1_T13, dfa1_T17, dfa1_T10, dfa1_T8, 
     dfa1_T8, dfa1_T8, dfa1_T8, dfa1_T8, dfa1_T14, dfa1_T3, dfa1_T3, dfa1_T3, 
     dfa1_T15
 };
@@ -4024,7 +4064,7 @@
 {
     dfa2_T15, dfa2_T13, dfa2_T13, dfa2_T0, dfa2_T3, dfa2_T7, dfa2_T8, dfa2_T19, 
     dfa2_T18, dfa2_T3, dfa2_T2, dfa2_T1, dfa2_T10, dfa2_T5, dfa2_T5, dfa2_T9, 
-    _empty, _empty, dfa2_T6, dfa2_T12, dfa2_T11, dfa2_T14, dfa2_T4, dfa2_T12, 
+    NULL, NULL, dfa2_T6, dfa2_T12, dfa2_T11, dfa2_T14, dfa2_T4, dfa2_T12, 
     dfa2_T12, dfa2_T12, dfa2_T12, dfa2_T12, dfa2_T16, dfa2_T1, dfa2_T1, 
     dfa2_T1, dfa2_T17
 };
A lot of same differences.


BTW, maybe we can update it to 5.0.1?
https://gitlab.linphone.org/BC/public/belle-sip/-/blob/master/CHANGELOG.md
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 11:41:05 UTC
Version 5.1.0.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 11:49:19 UTC
5.1.32
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-15 16:50:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d6a4b03cc35791f60731bb8b21861ad90f9dd856

commit d6a4b03cc35791f60731bb8b21861ad90f9dd856
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-06-15 16:46:52 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-06-15 16:46:52 +0000

    net/belle-sip: Update version 1.6.3=>5.1.32

    - Update MASTER_SITES
    - Update LICENSE_FILE

    PR:             264680
    Reported by:    vvd@unislabs.com
    Relnotes: https://gitlab.linphone.org/BC/public/belle-sip/-/tags/5.1.32

 net/belle-sip/Makefile                             | 27 ++++++++------------
 net/belle-sip/distinfo                             |  8 +++---
 .../files/patch-src-belle_sip_headers_impl.c       | 19 +++++++-------
 .../files/patch-src_belle__sip__internal.h         |  4 +--
 net/belle-sip/files/patch-src_dns.c (gone)         | 10 --------
 net/belle-sip/files/patch-src_dns_dns.c (new)      | 29 ++++++++++++++++++++++
 net/belle-sip/pkg-plist                            | 13 ++++++----
 7 files changed, 62 insertions(+), 48 deletions(-)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 18:34:12 UTC
Thanks!

libbellesip.so.0 => libbellesip.so.1
Maybe increment PORTREVISION for consumers (for example net/liblinphone).
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 19:08:28 UTC
net/liblinphone 3.12.0 build fails with new version of net/bctoolbox 5.1.38.
There is new version of net/liblinphone 5.1.44: https://gitlab.linphone.org/BC/public/liblinphone/-/tree/5.1.44

And net/linphone 4.1.1 => 4.4.6: https://gitlab.linphone.org/BC/public/linphone-desktop/-/tree/4.4.6
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-06-15 19:08:58 UTC
(In reply to VVD from comment #5)
Patience. Working on upgrading the entire ecosystem. :D
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 19:11:27 UTC
Thanks a lot!
Waiting.
Comment 8 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-06-15 23:22:16 UTC
(In reply to VVD from comment #7)
Looks like you have to wait more. Although I have upgraded and added some new ports for the dependencies liblinphone will require certain amount of finesse from me. :'(
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 23:25:40 UTC
(In reply to Muhammad Moinur Rahman from comment #8)
I see: https://cgit.freebsd.org/ports/log/ :-]
No problem! I can finish upgrade tomorrow.
Comment 10 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-06-16 16:32:03 UTC
(In reply to VVD from comment #9)
Looks like newer linphone is harder to run in FreeBSD. I have been able to port an older version of 5.0.X branch for now. I will look into bringing the more recent version into the tree. Enjoy.
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-17 22:30:02 UTC
(In reply to Muhammad Moinur Rahman from comment #10)
Thanks.

But net/linphone fails to build with too new bctoolbox:
===>  Configuring for linphone-4.1.1_6,1
===>  Performing out-of-source build
/bin/mkdir -p /tmp/work/usr/ports/net/linphone/work/.build
-- The C compiler identification is Clang 13.0.0
-- The CXX compiler identification is Clang 13.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test SUGGEST_OVERRIDE
-- Performing Test SUGGEST_OVERRIDE - Success
CMake Error at CMakeLists.txt:101 (find_package):
  By not providing "FindBcToolbox.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "BcToolbox", but CMake did not find one.

  Could not find a package configuration file provided by "BcToolbox" with
  any of the following names:

    BcToolboxConfig.cmake
    bctoolbox-config.cmake

  Add the installation prefix of "BcToolbox" to CMAKE_PREFIX_PATH or set
  "BcToolbox_DIR" to a directory containing one of the above files.  If
  "BcToolbox" provides a separate development package or SDK, be sure it has
  been installed.


-- Configuring incomplete, errors occurred!
Comment 12 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-06-17 22:36:41 UTC
(In reply to VVD from comment #11)
Oops. I really forgot about it. And it will be delayed. This is race weekend for me. Sorry.