Bug 264681 - multimedia/qmmp-qt5: Adjust default settings
Summary: multimedia/qmmp-qt5: Adjust default settings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-15 11:44 UTC by Daniel Engberg
Modified: 2022-08-22 18:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (fluffy)

Attachments
Patch for qmmp (1.20 KB, patch)
2022-06-15 11:44 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-15 11:44:49 UTC 
Created attachment 234699 [details]
Patch for qmmp

FFmpeg already supports aac and mp3 formats, disable redudant libraries (FAAD, MAD, MPG123)
While at it, disable MMS protocol support (Microsoft deprecated MMS in 2003)
MMS support should preferably also be completely removed due to the above (in a separate commit?)

References:
https://sourceforge.net/p/qmmp-dev/code/HEAD/tree/branches/qmmp-1.6/src/plugins/Input/ffmpeg/decoderffmpegfactory.cpp (L71 and below)
https://en.wikipedia.org/wiki/Microsoft_Media_Server
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-06-16 07:28:56 UTC 
Also related, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264708
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-22 17:58:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f744e2f9cd0f434a3065bc4289c4d6f4b5a5d168

commit f744e2f9cd0f434a3065bc4289c4d6f4b5a5d168
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2022-08-22 17:51:13 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2022-08-22 17:58:00 +0000

    multimedia/qmmp*-qt5: register conflicts with -qt6 versions (+)

    While here, drop outdated dependencies from default options [1]

    PR:     264681 [1]

 multimedia/qmmp-plugin-pack-qt5/Makefile |  2 +-
 multimedia/qmmp-qt5/Makefile             | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 3 Dima Panov freebsd_committer freebsd_triage 2022-08-22 18:03:01 UTC 
Pushed, thanks!