Bug 264684 - graphics/leptonica: fails to detect graphics/openjpeg 2.5.0
Summary: graphics/leptonica: fails to detect graphics/openjpeg 2.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/DanBloomberg/lepto...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-15 11:59 UTC by Vladimir Druzenko
Modified: 2022-07-18 15:26 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (hiroto.kagotani)

Attachments
Support build with OpenJPEG 2.5 (2.25 KB, patch)
2022-06-17 06:26 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-15 11:59:25 UTC 
Details and my "workaround patch" are here: https://github.com/DanBloomberg/leptonica/issues/623
Patch from upstream is here: https://github.com/DanBloomberg/leptonica/pull/624

Can maintainer, please, check patch from upstream and add it to port or my workaround patch if upstream's patch is "bad".

Thanks!
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-17 06:26:45 UTC 
Created attachment 234747 [details]
Support build with OpenJPEG 2.5

My workaround patch before upstream commit their version.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-17 07:12:36 UTC 
I explore a bit and it's look like hard work to separate required commits or backport patch - too much changes from last release in build subsystem.

I tested git master - build without errors, but update port to git master isn't good choice, IMHO.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2022-07-01 15:51:37 UTC 
How to ask for maintainer timeout?
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-07-17 21:34:37 UTC 
ping

maintainer timeout?
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-07-18 06:35:39 UTC 
Use upstream's fix instead?
https://github.com/DanBloomberg/leptonica/commit/14902fefab1922a948c7055a155cccec25924b8a
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-18 08:48:24 UTC 
(In reply to Daniel Engberg from comment #5)
There is already another patch being pulled from GH. When the first one is applied, the second one fails to apply due to missmatched offsets.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2022-07-18 09:30:42 UTC 
(In reply to Daniel Engberg from comment #5)
As I said in #2:
> I explore a bit and it's look like hard work to separate required commits or
> backport patch - too much changes from last release in build subsystem.

I see 2 ways:
1. Update port to current commit in git master.
2. Get my hack-patch as basis (with or without changes).
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-07-18 15:26:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cd714f2f4e30a136df40f77eafd79448ca11c90a

commit cd714f2f4e30a136df40f77eafd79448ca11c90a
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2022-07-18 08:54:30 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-18 15:23:17 +0000

    graphics/leptonica: fix build with openjpeg 2.5.0

    ChangeLog: https://github.com/DanBloomberg/leptonica/issues/623

    Fix detection of openjpeg 2.5.0

    PR:     264684
    Reported by:    vvd@unislabs.com
    Approved by:    hiroto.kagotani@gmail.com (maintainer, timeout > 1 month)

 graphics/leptonica/files/patch-openjpeg-2.5 (new) | 59 +++++++++++++++++++++++
 1 file changed, 59 insertions(+)
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-18 15:26:38 UTC 
Committed,

Sorry for the delay.

Thanks!