Bug 264714 - misc/amanda-server: upgrade to 3.5.1
Summary: misc/amanda-server: upgrade to 3.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-16 13:54 UTC by Trond Endrestøl
Modified: 2023-08-13 09:51 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-


Attachments
Patch for misc/amanda-server, upgrading the port to 3.5.1 (20.22 KB, patch)
2022-06-16 13:54 UTC, Trond Endrestøl
no flags Details | Diff
Patch for perl/Amanda/Status.pm disabling a die statement when taper status has an unexpected value (488 bytes, patch)
2022-06-29 06:20 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2022-06-16 13:54:04 UTC
Here's a preliminary update to AMANDA 3.5.1.

I decided to remove /usr/local/etc/amanda/amanda-security.conf from the pkg-plist. It's better for everyone to create this file as needed and not have it overwritten on every update of the server package.

I had to manually add -lssl to the LIBS variable in one of the patches. I'm sure there's a better way of doing this.

I'll conduct a test in my own production environment tonight, my time, CEST. The backup server is running 3.5.1 both as server and client. One client has been upgraded to 3.5.1, while the other clients are still at 3.3.9. Running amcheck hasn't revealed anything yet.

This change is in need of a proper shakedown. All assistance possible is most welcome.

Patch in the Git format for the ports tree will follow shortly.
Comment 1 Trond Endrestøl 2022-06-16 13:54:52 UTC
Created attachment 234728 [details]
Patch for misc/amanda-server, upgrading the port to 3.5.1
Comment 2 Trond Endrestøl 2022-06-29 06:20:43 UTC
Created attachment 234991 [details]
Patch for perl/Amanda/Status.pm disabling a die statement when taper status has an unexpected value

During my testing I had a few occurrences of:

Fri Jun 24 23:32:01.431301155 2022: pid 65817: thd-0x803589e00: taper: critical (fatal): log file write error: No space left on device

This was due to having too tight reservations and quotas in the zpool. The error went away once I removed the reservations and quotas.

This error also made amstatus die prematurely. For production use I suggest we disable the die statement proposed in the attached patch. I think its better to get the current status regardless of the outcome of the taper process.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-08-05 13:49:43 UTC
Maintainer timeout.

Do you have a changelog to this update?
Comment 4 Trond Endrestøl 2023-08-07 06:46:36 UTC
(In reply to Robert Clausecker from comment #3)
From https://www.zmanda.com/amanda-community/?ss360SearchTerm=3.5.1:

===cut===
Release 3.5.1
The 3.5.1 version of Amanda comprised of following features and enhancements.
Compilation on Solaris
Do not check all 'r' bit on suid binary
Fix parsing of configuration override (-o)
Can unset some setting
Client code will not fail if shared memory is not available
amreport
Significant enhancements
Allow '*' for a datestamp wildcard
amgetconf
Print an empty string if a parameter is not set instead of 'no such parameter'
amdump
New --no-dump, --no-flush and --no-vault argument
amstatus fix
Lock holding disk to protect multiple parallel access
===cut===

BTW, I noticed 3.5.3 was released in early May 2023.
https://www.zmanda.com/blog/introducing-amanda-3-5-3-elevated-security-for-your-backup-environment/
I'll see if I can get that version up & running too.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 10:05:10 UTC
(In reply to Trond Endrestøl from comment #4)

Looks good.  Port should have LICENSE set, which I'll try to get done.
I'll also fix some small issues here and there and regenerate the patches.

I'll go ahead and see that I can get this committed with my next batch.

A patch to go to 3.5.3 would be nice, too.  Would you be interested in taking up maintainership of this port?
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-08-09 13:05:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e8114fa589d7e8f302cc4f22e0315b1a2fac5308

commit e8114fa589d7e8f302cc4f22e0315b1a2fac5308
Author:     Trond Endrestøl <Trond.Endrestol@ximalas.info>
AuthorDate: 2023-08-07 10:03:09 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-09 13:01:14 +0000

    misc/amanda-server: update to 3.5.1

     - define LICENSE
     - simplify handling of USERS and GROUPS
     - reorder make variables in accordance with policy
     - regenerate patches
     - harden amstatus against task death

    Changelog: https://www.zmanda.com/amanda-community/?ss360SearchTerm=3.5.1

    PR:             264714
    Approved by:    fbsd@dylanleigh.net (maintainer timeout)

 misc/amanda-server/Makefile                        |  47 +++---
 misc/amanda-server/distinfo                        |   6 +-
 .../files/patch-amandad-src__Makefile.in           |  10 +-
 .../files/patch-amar-src__Makefile.in              |  10 +-
 .../files/patch-client-src__sendbackup-dump.c      |   6 +-
 .../{patch-ad => patch-client-src_calcsize.c}      |   6 +-
 .../files/patch-common-src__Makefile.in            |  21 ++-
 misc/amanda-server/files/patch-man__Makefile.in    |  10 +-
 .../files/patch-ndmp-src__Makefile.in              |   6 +-
 .../files/patch-perl__Amanda__Process.pm           |   6 +-
 .../files/patch-perl__Amanda__Status.pm (new)      |  11 ++
 .../files/patch-perl__amglue__Makefile.in (gone)   |  10 --
 .../files/patch-perl_amglue_Makefile.in (new)      |  10 ++
 .../files/patch-xfer-src__Makefile.in              |   8 +-
 misc/amanda-server/pkg-plist                       | 188 ++++++++++++++-------
 15 files changed, 220 insertions(+), 135 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-08-13 09:51:28 UTC
Thank you for your contribution.