please update to 1.2.1 so we can use pyfuse3 - https://github.com/borgbackup/borg/releases/tag/1.2.1
Upstream notes special consideration for 1.1 -> 1.2 upgrades - Should we fork off a new borgbackup11 allowing users to upgrade at a time of their choosing? - What UPDATING instructions and/org pkg-message messaging can we include to ensure users are aware and informed of approriate upgrade procedures and risks? Also, bug 264815 should be committed first, so that it can be merged to quarterly prior to and independent from this version update.
Hi, I need some time to ensure that 1.2.X versions works fine on FreeBSD. So far I have submitted an update to 1.1.18 version (the last version of 1.1.x series).
Created attachment 235890 [details] proposed patch to update to 1.2.1 and add self-tests and "make test" support
Created attachment 235891 [details] v2 patch to also install manual pages let's add manual pages, too
(In reply to Jose G. Juanino from comment #2) I need to push a bit because this is now six weeks old and my smoke tests seem to run fine on 12.1-RELEASE-pwhatever i386 and on amd64 with 13.0-RELEASE-pXX and 13.1-RELEASE-p1. Please review my patch proposal; tarball's signature (WRT distinfo update) has been verified OK.
Created attachment 235892 [details] v2.1 patch (minor cleanups, new commit message proposal) [PATCH] archivers/py-borgbackup: update to 1.2.1, add tests & man pages Update to v1.2.1 [1] Add self-test features [1], including - a smoke test in post-install in order to always run it - "make test" support (requires network access for tox) PR: 264816 [1] Reported by: rob2g2-freebsd@bitbert.com [1] Add manual pages. [2] PR: 263269 [2] Reported by: courtney.hicks1@icloud.com [2] --- archivers/py-borgbackup/Makefile | 48 ++++++++++++++++++++++++++----- archivers/py-borgbackup/distinfo | 6 ++-- archivers/py-borgbackup/pkg-plist | 35 ++++++++++++++++++++++ 3 files changed, 79 insertions(+), 10 deletions(-) create mode 100644 archivers/py-borgbackup/pkg-plist
Created attachment 235893 [details] v2.1 (for real) with minor cleanups, see above for suggested commit message
Note that depending on when (time-wise) exactly we will have a working approved 1.2.x port of borgbackup in relation to the quarterly branch time (2022-10-01 is the nominal date to branch 2022Q4), we may want to add the update as a new py-borgbackup12 port instead and keep 1.1.y as the py-borgbackup port for a while, so as to reduce astonishment and not force migrations on users. The upstream's upgrade instructions are under "Upgrade notes:" here https://borgbackup.readthedocs.io/en/1.2-maint/changes.html#change-log The "borg won't start" issue we have just solved in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265060 was painful enough for the port's users, we should avoid hurting them again. Backup is a sensitive topic. Also note that I see two self-test failures from "make test" with my proposed update. I have not investigated them up close yet. Expect "make test" to run for like 15 minutes even on reasonably fast computers under Python 3.9, or else, longer.
For purposes of the upgrade and on second thought of schedules, we would need: - a rename of the existing backup as py-borgbackup11, adding the new one as py-borgbackup - unless we run late in this quarter of 2022 (but then we may just defer the commit until after the branch date just as well) - possibly (to be discussed) a MOVED entry (for ports/MOVED) documenting the rename, - an UPDATING entry describing how to stick with the 1.1.x version, or how to upgrade otherwise
Hi, I have returned from my vacation time some days ago, but sadly I am very busy currently. I need that something take charge of this port (taking the maintainership) in order to carry out the upgrade to 2.1 version. Thank you very much to the FreeBSD community!
OK, I will take maintainership in the interim, but since I have a rather low usage profile for borgbackup, I will happily pass this on to another maintainer. I am currently testing an upgrade that will: - preserve 1.1.18_2 as a py-borgbackup11 port, while adding the self-test and manual fixes from the 1.2 update I have proposed earlier - update the mainline port to 1.2.2 which has been released on Aug 20.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=223e50238c56ef71b07e048d6aadfcf6dab9e03a commit 223e50238c56ef71b07e048d6aadfcf6dab9e03a Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2022-08-13 21:58:49 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2022-09-03 14:33:11 +0000 archivers/py-borgbackup: update to 1.2.2+man+test, preserve 1.1 Take maintainership, because original maintainer asked for a new maintainer, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264816#c10 ¡Muchas gracias, José! Thanks for maintaining the port thus far. If there is a potential maintainer who is using BorgBackup at scale, I will be happy to pass maintainership on. Update to v1.2.2 [1, was for 1.2.1], preserve the earlier 1.1.18 version (also with manpages and self-tests added, hence bumping PORTREVISION) as py-borgbackup11, and document this in UPDATING. ChangeLog: https://www.borgbackup.org/releases/borg-1.2.html Add self-tests [1] to both 1.1 and 1.2, including - a smoke test in post-install in order to always run it - "make test" support (requires network access for tox) PR: 264816 [1] Reported by: rob2g2-freebsd@bitbert.com [1] Add manual pages to both 1.1 and 1.2. [2] PR: 263269 [2] Reported by: courtney.hicks1@icloud.com [2] UPDATING | 15 ++++++- archivers/Makefile | 1 + archivers/py-borgbackup/Makefile | 48 +++++++++++++++++---- archivers/py-borgbackup/distinfo | 6 +-- archivers/py-borgbackup/pkg-plist (new) | 35 ++++++++++++++++ archivers/py-borgbackup11/Makefile (new) | 65 +++++++++++++++++++++++++++++ archivers/py-borgbackup11/distinfo (new) | 3 ++ archivers/py-borgbackup11/pkg-descr (new) | 11 +++++ archivers/py-borgbackup11/pkg-message (new) | 28 +++++++++++++ archivers/py-borgbackup11/pkg-plist (new) | 33 +++++++++++++++ 10 files changed, 233 insertions(+), 12 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=12d7dba8b2e1b11e76dd0ae5c5c60ed3da45a50e commit 12d7dba8b2e1b11e76dd0ae5c5c60ed3da45a50e Author: Matthias Andree <mandree@FreeBSD.org> AuthorDate: 2022-09-03 18:47:24 +0000 Commit: Matthias Andree <mandree@FreeBSD.org> CommitDate: 2022-09-03 18:50:19 +0000 archivers/py-borgbackup*: staging without HOME Building as non-root often inherits the "nobody" user's would-be home directory, "/nonexistent", which is just that. Provide something blank in the WRKDIR instead. Reported by: Juraj Lutter (otis@) Unrelated to, but still mentioned for... PR: 264816 archivers/py-borgbackup/Makefile | 6 ++++-- archivers/py-borgbackup11/Makefile | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-)