Bug 264882 - games/xnethack: fix behaviour with mismatched lua version
Summary: games/xnethack: fix behaviour with mismatched lua version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-25 05:03 UTC by Robert Clausecker
Modified: 2022-06-25 14:30 UTC (History)
1 user (show)

See Also:


Attachments
games/xnethack: fix behaviour with mismatched lua version (3.83 KB, patch)
2022-06-25 05:03 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-06-25 05:03:20 UTC
Created attachment 234928 [details]
games/xnethack: fix behaviour with mismatched lua version

The latest version of the package has introduced a "lua sandbox" that
comes with a version check against the bundled lua version.

As we unbundle lua, we cannot ensure that this version check succeeds.
Removal of the version check allows us to build a working binary, but
it is uncertain if there are any residual effects from the version
mismatch.

To rule out that possibility, the sandbox code is left disabled by
default but can be enabled if desired through the SANDBOX option.

Tested with Poudriere on arm64 FreeBSD 13.1.
If 2022Q3 drops before this is committed, please MFH the change.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-06-25 14:30:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f055dad0314f34264ccc320846b49340bd27dd0

commit 4f055dad0314f34264ccc320846b49340bd27dd0
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-06-25 04:58:18 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-06-25 14:28:19 +0000

    games/xnethack: fix behaviour with mismatched lua version

    The latest version of the package has introduced a "lua sandbox" that
    comes with a version check against the bundled lua version.

    As we unbundle lua, we cannot ensure that this version check succeeds.
    Removal of the version check allows us to build a working binary, but
    it is uncertain if there are any residual effects from the version
    mismatch.

    To rule out that possibility, the sandbox code is left disabled by
    default but can be enabled if desired through the SANDBOX option.

    PR:             264882

 games/xnethack/Makefile                      |  9 ++++++-
 games/xnethack/files/patch-include-config.h  |  9 +++++++
 games/xnethack/files/patch-src_nhlua.c (new) | 40 ++++++++++++++++++++++++++++
 3 files changed, 57 insertions(+), 1 deletion(-)