Bug 264937 - audio/libmad: Update to 0.16.2
Summary: audio/libmad: Update to 0.16.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/tenacityteam/libma...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-28 07:12 UTC by Daniel Engberg
Modified: 2022-07-12 09:20 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for libmad (1.22 KB, patch)
2022-06-28 07:12 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-28 07:12:00 UTC 
Created attachment 234978 [details]
Patch for libmad

Update to 0.16.2 and backport commit 9ec2efa6ba4bfaed7805867077d3a67daa022331 to enable 64-bit math on aarch64

Tested on RockPro64 with madplay and sox
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-06-29 13:07:24 UTC 
Tested successfully with Poudriere on armv7 arm64 FreeBSD 13.1.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-29 19:22:54 UTC 
Last versions of libmad have lib/libmad.so.0.16.x and lib/libmad.so.
After every update I get this:
# pkg check -d
Checking all packages: 100%
audacity is missing a required shared library: libmad.so.0.16.1
cdrdao is missing a required shared library: libmad.so.0.16.1
k3b is missing a required shared library: libmad.so.0.16.1
libxine is missing a required shared library: libmad.so.0.16.1
mpg321 is missing a required shared library: libmad.so.0.16.1
sox is missing a required shared library: libmad.so.0.16.1
vlc is missing a required shared library: libmad.so.0.16.1

AFAIR, it start after this commit:
https://cgit.freebsd.org/ports/commit/audio/libmad?id=519c89efe3a9ddc8f3a57d1bb4940ff355086576

I think it's USES=cmake "side effect".
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-06-29 19:26:42 UTC 
No, users needs to be bumped (PORTREVISION)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-07-09 20:59:21 UTC 
Sunpoet, can we add the aarch64 patch?
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-11 14:22:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e02c598a80af418d4a4be7c112c33dd542cc8b97

commit e02c598a80af418d4a4be7c112c33dd542cc8b97
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-07-11 14:21:46 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-07-11 14:21:46 +0000

    audio/libmad: Allow aarch64 to use 64-bit fixed point math

    PR:             264937
    Reported by:    diizzy

 audio/libmad/Makefile | 3 +++
 audio/libmad/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-07-11 14:24:15 UTC 
Committed. Thanks!
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2022-07-12 09:20:42 UTC 
(In reply to VVD from comment #2)
Fixed in https://cgit.freebsd.org/ports/commit/?id=390e09a82cda665f8742df005574f673fd130545