Bug 264942 - x11/babl: fix build on armv7
Summary: x11/babl: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-28 13:58 UTC by Robert Clausecker
Modified: 2022-07-01 02:04 UTC (History)
2 users (show)

See Also:
fluffy: maintainer-feedback+
fluffy: merge-quarterly+

Attachments
x11/babl: fix build on armv7 (1.68 KB, patch)
2022-06-28 13:58 UTC, Robert Clausecker 		fuz: maintainer-approval? (gnome)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-06-28 13:58:12 UTC 
Created attachment 234983 [details]
x11/babl: fix build on armv7

We use a different method for fetching ELF aux vectors on FreeBSD.

Tested with poudriere on armv7 arm64 FreeBSD 13.
Please MFH if 2022Q3 has dropped by the time this is applied.
Comment 1 Dima Panov freebsd_committer freebsd_triage 2022-06-28 16:48:12 UTC 
Is this affect arm6 too? 

I haven't any arm machine to run own tests :(
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-06-28 16:52:45 UTC 
Unfortunately I've grilled my last armv6 box a while ago and will have to buy a new one.  But I'm positive it affects armv6, too, as armv6 and armv7 have the same header files.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-30 21:45:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb0f1da1920c245641a1f8a03dc17051631e66f0

commit bb0f1da1920c245641a1f8a03dc17051631e66f0
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2022-06-30 21:44:03 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2022-06-30 21:45:19 +0000

    x11/babl: fix build on armv7

    PR:     264942
    Submitted by:   Robert Clausecker

 x11/babl/files/patch-babl_babl-cpuaccel.c (new) | 43 +++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2022-07-01 02:04:03 UTC 
Thank you for committing this change.