Bug 264969 - [exp-run]: Remove API compat shims for DRIVER_MODULE on main
Summary: [exp-run]: Remove API compat shims for DRIVER_MODULE on main
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on: 265456 265458
Blocks:
  Show dependency tree / graph
 
Reported: 2022-06-30 22:34 UTC by John Baldwin
Modified: 2022-08-23 16:39 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2022-06-30 22:34:16 UTC 
Please build a world with the patch from https://reviews.freebsd.org/D35168.

I have already fixed all of the ports named *-kmod as well as nvidia-driver (you can see the reviews for those linked to the commit in the stack in Phab).  Hopefully there aren't any other stragglers.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2022-07-06 08:39:33 UTC 
Some failure logs:

http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/cx88-1.5.4.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/dpdk-19.11.12.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/dpdk20.11-20.11.5.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/mbgtools-f.1.0.0.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/oss-4.2.b2019_2.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/parallels-tools-0.1.2_1.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/pwcbsd-1.4.1_12.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/uarduno-1.02_1.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/virtualbox-ose-additions-6.1.34.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/virtualbox-ose-additions-legacy-5.2.44_3.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/virtualbox-ose-additions-nox11-6.1.34.log
http://gohan04.nyi.freebsd.org/data/main-amd64-PR264969-default/2022-07-04_15h45m23s/logs/errors/virtualbox-ose-additions-nox11-legacy-5.2.44_3.log
Comment 2 Bob Frazier 2022-07-28 19:06:15 UTC 
the patch for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265458 is fine.  commented there also.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-23 16:39:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9e4e7bcaef3fcaab66cdecd08b1664ac92cc9a6b

commit 9e4e7bcaef3fcaab66cdecd08b1664ac92cc9a6b
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-08-23 16:36:41 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-08-23 16:38:09 +0000

    *DRIVER_MODULE*: Remove the compat shims to accept the devclass argument.

    PR:             264969 (exp-run)
    Differential Revision:  https://reviews.freebsd.org/D35168

 sys/sys/bus.h | 62 ++++++++++-------------------------------------------------
 1 file changed, 10 insertions(+), 52 deletions(-)