Created attachment 235058 [details] Patch to fix deprecated uses of defined(@array) Perl no longer allows defined(@array) The full error is: Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /usr/local/lib/perl5/site_perl/GNUpod/XMLhelper.pm line 362. Compilation failed in require at /usr/local/bin/gnupod_search.pl line 25. BEGIN failed--compilation aborted at /usr/local/bin/gnupod_search.pl line 25. I have submitted these patches years ago to the maintainer ports@ But, it has not yet been applied, please do. I have to add it this manually every time and gnupod is unusable without this fix. With this fix it works fine and I use it regularly. Many thanks, I can take on maintainer for this port if no-one else will.
Hi Stephen, thanks for the patch. Could you: * Upload a patch for the port. * Add yourself as maintainer for the port. Thanks!
Created attachment 235677 [details] Patch against /usr/ports/audio/gnupod This patch adds a patch to /usr/ports/audio/gnupod to fix breakage caused by changes in perl over the years, and it also adds myself as the maintainer.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=50964af9333cb62250c52ef6849a47b7dd5f7baa commit 50964af9333cb62250c52ef6849a47b7dd5f7baa Author: Stephen Roome <steve.roome@gmail.com> AuthorDate: 2022-08-04 11:23:14 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-08-05 05:25:23 +0000 audio/gnupod: fix deprecated use of defined(@array) Submitter becomes maintainer. First port to be maintained by submitter. PR: 265018 Reported by: steve.roome@gmail.com MFH: 2022Q3 audio/gnupod/Makefile | 2 +- audio/gnupod/files/patch-to-fix-gnupod.txt (new) | 35 ++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d50ea47bcf741415d9f214f008094fea18d67f8f commit d50ea47bcf741415d9f214f008094fea18d67f8f Author: Stephen Roome <steve.roome@gmail.com> AuthorDate: 2022-08-04 11:23:14 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-08-05 05:28:08 +0000 audio/gnupod: fix deprecated use of defined(@array) Submitter becomes maintainer. First port to be maintained by submitter. PR: 265018 Reported by: steve.roome@gmail.com MFH: 2022Q3 (cherry picked from commit 50964af9333cb62250c52ef6849a47b7dd5f7baa) audio/gnupod/Makefile | 2 +- audio/gnupod/files/patch-to-fix-gnupod.txt (new) | 35 ++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
Committed and merged to 2022Q3. Thanks!