Bug 265034 - math/armadillo: Update to 11.2.2, add tests
Summary: math/armadillo: Update to 11.2.2, add tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-04 18:19 UTC by Yuri Victorovich
Modified: 2022-07-05 16:23 UTC (History)
1 user (show)

See Also:
salvadore: maintainer-feedback+


Attachments
patch (1.73 KB, patch)
2022-07-04 18:19 UTC, Yuri Victorovich
salvadore: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2022-07-04 18:19:15 UTC
Created attachment 235069 [details]
patch

Additional changes:
* not build tests during build target
* change PORTVERSION -> DISTVERSION
* minor format improvement
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-07-04 18:51:44 UTC
Comment on attachment 235069 [details]
patch

^Triage: Please set the maintainer-approval attachment flag (to ?) and set the requestee field to the e-mail address of the maintainer to ask for maintainer approval

Attachment -> Details -> maintainer-approval [?]

-------

Thanks, Yuri. I had already prepared a patch to update the port to version 11.2.1, but yours is better, since you update it to a newer version and also add testing.

I will probably need some time to test it: since lang/gcc11 has now LTO_BOOTSTRAP enabled by default, I have either to wait for gcc11 packages to be ready or to build my own packages (without bootstrap). If however you have already tested successfully the patch, I trust you and you can consider the patch approved (and I will set the maintainer-approval flag accordingly).
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-04 18:56:19 UTC
(In reply to Lorenzo Salvadore from comment #1)

Hi Lorenzo,

I didn't rebuild all dependencies, only some of them.

There's no rush. Please test it.


Thanks,
Yuri
Comment 3 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-07-05 11:59:56 UTC
Comment on attachment 235069 [details]
patch

Patch tested successfully and approved, thanks again.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-05 16:22:41 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-05 16:23:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a7246273648389731676382c7485cbdbcdc84ff

commit 4a7246273648389731676382c7485cbdbcdc84ff
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-07-05 16:20:18 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-07-05 16:22:20 +0000

    math/armadillo: Update 11.2.0 -> 11.2.2

    Additional changes:
    * not build tests during build target
    * change PORTVERSION -> DISTVERSION
    * minor format improvement

    PR:             265034
    Approved by:    salvadore@ (maintainer)

 math/armadillo/Makefile  | 9 +++++----
 math/armadillo/distinfo  | 6 +++---
 math/armadillo/pkg-plist | 2 +-
 3 files changed, 9 insertions(+), 8 deletions(-)