Bug 265165 - x11-wm/xfce4-session: Add x11/xrdb to RUN_DEPENDS
Summary: x11-wm/xfce4-session: Add x11/xrdb to RUN_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 08:23 UTC by Alexander Vereeken
Modified: 2022-07-12 13:16 UTC (History)
3 users (show)

See Also:
madpilot: merge-quarterly+

Attachments
0001-x11-wm-xfce4-session-Add-x11-xrdb-to-RUN_DEPENDS.patch (96.29 KB, patch)
2022-07-12 08:23 UTC, Alexander Vereeken 		no flags Details | Diff
0002-x11-wm-xfce4-session-Add-x11-xrdb-to-RUN_DEPENDS.patch (978 bytes, patch)
2022-07-12 08:53 UTC, Alexander Vereeken 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Vereeken 2022-07-12 08:23:24 UTC 
Created attachment 235209 [details]
0001-x11-wm-xfce4-session-Add-x11-xrdb-to-RUN_DEPENDS.patch

From $HOME/.xsession-errors:

`/usr/local/etc/xdg/xfce4/xinitrc: xrdb: not found`

I do use the xorg-minimal metapackage instead of the xorg one.
Comment 1 Alexander Vereeken 2022-07-12 08:28:24 UTC 
Patch contains old stuff, i do generate a new one.
Comment 2 Alexander Vereeken 2022-07-12 08:53:47 UTC 
Created attachment 235210 [details]
0002-x11-wm-xfce4-session-Add-x11-xrdb-to-RUN_DEPENDS.patch
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2022-07-12 09:29:37 UTC 
Hi,

Thanks for the patch.

Definitely this went unnoticed because the binary package and I guess most users are using the full xorg port/package, so don't notice the missing dependency, since it's installed anyway.

I'll work on this shortly.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-12 13:14:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2c25ab61821fe05f1ff529a503b4cae4d145e57e

commit 2c25ab61821fe05f1ff529a503b4cae4d145e57e
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2022-07-12 13:10:30 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-07-12 13:13:52 +0000

    x11-wm/xfce4-session: Add runtime depend on xrdb

    The included xinitrc script uses the xrdb program.

    It is installed by default by the full xorg metaport, but not by
    the minimal version.

    PR:             265165
    MFH:            2022Q3

 x11-wm/xfce4-session/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-12 13:15:49 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ecdc5650b7ecd30c065101df62957f4857d99d42

commit ecdc5650b7ecd30c065101df62957f4857d99d42
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2022-07-12 13:10:30 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-07-12 13:15:06 +0000

    x11-wm/xfce4-session: Add runtime depend on xrdb

    The included xinitrc script uses the xrdb program.

    It is installed by default by the full xorg metaport, but not by
    the minimal version.

    PR:             265165
    MFH:            2022Q3
    (cherry picked from commit 2c25ab61821fe05f1ff529a503b4cae4d145e57e)

 x11-wm/xfce4-session/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2022-07-12 13:16:50 UTC 
Committed. Thanks!