Created attachment 235256 [details] textproc/man2html: update to 3.1.20220714 - switch to upstream provided dedicated tarball Upstream changes: - trim unwanted quotes from -title parameter which came from shellcheck fixes - adapt Schilling's subsection change - amend the hyphenation fix to account for href's pointing to a subdirectory. improve handling of hyphenated link by adding an option "-leftside" for the left-sides from hyphenated manpage names (with a short fallback for "apt", "cvs", "git", "sccs' and "sysv"). A changelog is included in the distfile, but not available online, hence the detailed commit message (please keep it). Tested with Poudriere on armv7 FreeBSD 13.
Hello, 'portfmt -D Makefile' gives some nice formating: --- --- Makefile +++ Makefile @@ -14,13 +14,15 @@ USES= perl5 shebangfix tar:tgz USE_PERL5= run +SHEBANG_FILES= man.cgi man2html -SHEBANG_FILES= man2html man.cgi NO_ARCH= yes NO_BUILD= yes CGIDIR= ${PREFIX}/www/cgi-bin +PLIST_FILES= bin/man2html \ + man/man1/man2html.1.gz \ + www/cgi-bin/man.cgi -PLIST_FILES= bin/man2html man/man1/man2html.1.gz www/cgi-bin/man.cgi ---
(...) and use DISTVERSION instead of PORTVERSION
(In reply to Nuno Teixeira from comment #2) If you like, please perform these two changes during commit. I do not usually use portfmt because it often wrecks deliberate deviations from its formatting algorithm in more complex ports.
(In reply to Robert Clausecker from comment #3) I usually follow portfmt and portclippy for small cosmetic changes like example above and of course, be carefull about what this tools changes.
(In reply to Nuno Teixeira from comment #4) Thank you for asking before performing these changes. I've had some bad experiences with ports committers who changed formatting without checking and made the Makefile a lot harder to read.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4e27d101e1ddfe398c72ebe5493a38b1ed621f95 commit 4e27d101e1ddfe398c72ebe5493a38b1ed621f95 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-07-15 20:53:49 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-07-15 20:58:05 +0000 textproc/man2html: Update to 3.1.20220714 - switch to DISTVERSION - switch to upstream provided dedicated tarball - pet portfmt ChangeLog: - trim unwanted quotes from -title parameter which came from shellcheck fixes - adapt Schilling's subsection change - amend the hyphenation fix to account for href's pointing to a subdirectory. improve handling of hyphenated link by adding an option "-leftside" for the left-sides from hyphenated manpage names (with a short fallback for "apt", "cvs", "git", "sccs' and "sysv") PR: 265212 textproc/man2html/Makefile | 27 ++++++++++----------------- textproc/man2html/distinfo | 8 +++----- 2 files changed, 13 insertions(+), 22 deletions(-)
Committed, thanks!