Bug 265285 - devel/fungw: touch up port as per upstream instructions
Summary: devel/fungw: touch up port as per upstream instructions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on: 265261
Blocks:
  Show dependency tree / graph
 
Reported: 2022-07-18 05:31 UTC by Robert Clausecker
Modified: 2022-07-18 19:27 UTC (History)
1 user (show)

See Also:

Attachments
devel/fungw: touch up port as per upstream instructions (20.00 KB, patch)
2022-07-18 05:31 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-18 05:31:43 UTC 
Created attachment 235323 [details]
devel/fungw: touch up port as per upstream instructions

Upstream has suggested various ways to improve the port.

 - replace Makefile patches with patch from upstream SVN
 - replace scconfig patches with configure arguments
 - replace bundled genht with devel/genht (see bug #265261)
 - fix WWW to point to www subdomain

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Portlint and portclippy are happy.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-07-18 07:26:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=de8de5dc0f2212b5641aaa777a2c6f8b927898ec

commit de8de5dc0f2212b5641aaa777a2c6f8b927898ec
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-18 07:22:43 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-07-18 07:25:07 +0000

    devel/fungw: touch up port as per upstream instructions

     - replace Makefile patches with patch from upstream SVN
     - replace scconfig patches with configure arguments
     - replace bundled genht with devel/genht (see bug #265261)
     - fix WWW to point to www subdomain
     - bump PORTREVISION

    PR:             265285

 devel/fungw/Makefile                               |  36 ++---
 devel/fungw/files/patch-MAKE (new)                 | 164 +++++++++++++++++++++
 devel/fungw/files/patch-Makefile (gone)            |  64 --------
 devel/fungw/files/patch-doc_Makefile.in (gone)     |  18 ---
 .../fungw/files/patch-libfungw_Makefile.in (gone)  |  25 ----
 .../files/patch-libfungwbind_Makefile.in (gone)    |  20 ---
 .../files/patch-libfungwbind_Plugin.tmpasm (gone)  |  25 ----
 .../files/patch-regression_Makefile.in (gone)      |  11 --
 ...tch-scconfig_src_scripts_find__duktape.c (gone) |  11 --
 .../patch-scconfig_src_scripts_find__lua.c (gone)  |  11 --
 .../files/patch-src__3rd_genht_Makefile (gone)     |  38 -----
 devel/fungw/pkg-descr                              |   2 +-
 devel/fungw/pkg-plist                              |  17 ---
 13 files changed, 180 insertions(+), 262 deletions(-)
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-18 07:27:52 UTC 
Hello,

I did a 'make makepatch' to pet portlint.

Committed, thanks!
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-07-18 14:52:29 UTC 
(In reply to Nuno Teixeira from comment #2)

Hi, the non-makepatch patch was intentional as it is a patch taken straight from upstream's SVN repository.  By applying makepatch to it, you destroyed this information.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-18 19:17:33 UTC 
patch is inaltered, it just been formated with 'make makepatch', you can confirm that with diff.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2022-07-18 19:27:14 UTC 
(In reply to Nuno Teixeira from comment #4)

Correct.  And that destroyed the information (by removing the SVN revision identifiers in the patch).