Bug 265293 - security/libpki: Fix LDAP option build
Summary: security/libpki: Fix LDAP option build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-18 11:06 UTC by Nuno Teixeira
Modified: 2022-07-21 06:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bruno)

Attachments
libpki-0.9.2_2: Fix LDAP option build (722 bytes, patch)
2022-07-18 11:06 UTC, Nuno Teixeira 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2022-07-18 11:06:54 UTC 
Created attachment 235330 [details]
libpki-0.9.2_2: Fix LDAP option build

Hi,

LDAP option is not building, there's the patch to solve it:

---
-LDAP_LIB_DEPENDS=      liblber.so:net/openldap24-client \
-                       libldap_r.so:net/openldap24-client[1]
+LDAP_USE=              OPENLDAP=yes
 LDAP_CONFIGURE_ENABLE= ldap
-LDAP_LDFLAGS+=         -llber[2]
---

[1] LDAP_USE=OPENLDAP=yes defaults to openldap version 2.6.3 and its the correct way to setup openldap dependency

[2] LDAP_LDFLAGS+=-llber is causing build to fail

Poudriere tests passes with all option 'on':
---
Architecture .........: bsd (64 bits)
Host System Type .....: amd64-portbld-freebsd14.0
Supported URLs .......: file http https ldap mysql pg dns
                                        ^^^^ ^^^^^ ^^ ^^^
---

Please test.

Cheers
Comment 1 Bruno Damour 2022-07-19 05:55:04 UTC 
Hello
I had tried to avoid pulling openldap as a port, and when I tried it it worked on my system (13.1) but it’s probably cleaner this way
Thanks
Bruno
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-19 07:01:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d1d115cf3b998b9036c514c29a48718df0d26c79

commit d1d115cf3b998b9036c514c29a48718df0d26c79
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2022-07-19 06:56:19 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-07-19 06:56:19 +0000

    security/libpki: Fix LDAP option build

     - use LDAP_USE= OPENLDAP=yes instead of LIB_DEPENDS on
       net/openldap24-client
     - remove LDAP_LDFLAGS+= llber  causing build to fail

    PR:             265293

 security/libpki/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-19 07:02:14 UTC 
Committed, thanks!
Comment 4 Bruno Damour 2022-07-20 11:41:04 UTC 
Hello,
Any idea why I keep getting notifications from fallout about build failure on arm64 even if I did set the NOT_FOR_ARCHS = arm64 in the Makefile ?
Bruno
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-07-20 11:52:31 UTC 
(In reply to Bruno Damour from comment #4)
Hi,

PORTREVISION=1 introduced NOT_FOR_ARCHS=arm64 as shown in https://cgit.freebsd.org/ports/commit/?id=ea1086f14d694235d0dd6df321edc270097793a3

Could you check fallout log that it is testing at least portrevision 1 or the latest 2?

Cheers
Comment 6 Bruno Damour 2022-07-21 06:58:33 UTC 
Hello,
Of course you were right, it was version 1, it seems to be fixed now.
Thanks
Bruno