Bug 265318 - devel/ctypes.sh: Fix build on FreeBSD 13
Summary: devel/ctypes.sh: Fix build on FreeBSD 13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL: https://github.com/taviso/ctypes.sh/i...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-19 17:52 UTC by Robert Clausecker
Modified: 2022-08-17 16:47 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
koobs: merge-quarterly?

Attachments
devel/ctypes.sh: fix build on FreeBSD 13 (4.35 KB, patch)
2022-07-19 17:52 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-19 17:52:20 UTC 
Created attachment 235365 [details]
devel/ctypes.sh: fix build on FreeBSD 13

FreeBSD 13 has the mempcpy function which was absent before.
Patch the port to add a configure test for this function.
Work around the port shipping an extra file named config.

While we are at it, also fix wrong getopt usage for platforms
where char is an unsigned type.

Tested with Poudriere on armv7 arm64 FreeBSD 13, arm64 FreeBSD 12.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-07-22 04:04:46 UTC 
Upstream issue opened: https://github.com/taviso/ctypes.sh/issues/57
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-08-05 16:58:44 UTC 
Comment on attachment 235365 [details]
devel/ctypes.sh: fix build on FreeBSD 13

maintainer timeout
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-08-05 16:58:56 UTC 
maintainer timeout
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-08-13 01:50:31 UTC 
^Triage: Reset Assignee, open to resolve

Approved by: portmgr (maintainer timeout, ~1 month)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:20:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e73c354895691d93cee78b2efe81e5b260f637e

commit 2e73c354895691d93cee78b2efe81e5b260f637e
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-17 05:59:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 16:16:10 +0000

    devel/ctypes.sh: Fix build on FreeBSD 13

    ChangeLog: https://github.com/taviso/ctypes.sh/issues/57

    While here change old WWW (not working)

    PR:             265318
    Reported by:    fuz@fuz.su (maintainer)
    Approved by:    portmgr (maintainer timeout, ~1 month)
    MFH:            2022Q3

 devel/ctypes.sh/Makefile  | 9 ++++++---
 devel/ctypes.sh/pkg-descr | 2 +-
 2 files changed, 7 insertions(+), 4 deletions(-)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-17 16:22:21 UTC 
Committed and merged to 2022Q3.

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:22:23 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1a028d3fb4a778d1762010eaa4075e6a8b08f8e9

commit 1a028d3fb4a778d1762010eaa4075e6a8b08f8e9
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-17 05:59:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 16:18:47 +0000

    devel/ctypes.sh: Fix build on FreeBSD 13

    ChangeLog: https://github.com/taviso/ctypes.sh/issues/57

    While here change old WWW (not working)

    PR:             265318
    Reported by:    fuz@fuz.su (maintainer)
    Approved by:    portmgr (maintainer timeout, ~1 month)
    MFH:            2022Q3

    (cherry picked from commit 2e73c354895691d93cee78b2efe81e5b260f637e)

 devel/ctypes.sh/Makefile  | 9 ++++++---
 devel/ctypes.sh/pkg-descr | 2 +-
 2 files changed, 7 insertions(+), 4 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:45:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=505d19cfeea99671eecfa7a151e2665eece96a5f

commit 505d19cfeea99671eecfa7a151e2665eece96a5f
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-08-17 16:40:36 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 16:40:36 +0000

    devel/ctypes.sh: Add missing patches

    Add patches missing from last update.

    PR:     265318
    Fixes:  79f9679c7e795de9a15451910526cea3ea50c21f

 devel/ctypes.sh/files/patch-configure.ac (new)       | 20 ++++++++++++++++++++
 devel/ctypes.sh/files/patch-include_builtins.h (new) | 13 +++++++++++++
 devel/ctypes.sh/files/patch-src_callback.c (new)     | 11 +++++++++++
 devel/ctypes.sh/files/patch-src_unpack.c (new)       | 11 +++++++++++
 4 files changed, 55 insertions(+)
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:47:29 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f8275f75cd903e78a3110e61f6b20edc64f38231

commit f8275f75cd903e78a3110e61f6b20edc64f38231
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-08-17 16:40:36 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 16:43:30 +0000

    devel/ctypes.sh: Add missing patches

    Add patches missing from last update.

    PR:     265318
    Fixes:  79f9679c7e795de9a15451910526cea3ea50c21f
    (cherry picked from commit 505d19cfeea99671eecfa7a151e2665eece96a5f)

 devel/ctypes.sh/files/patch-configure.ac (new)       | 20 ++++++++++++++++++++
 devel/ctypes.sh/files/patch-include_builtins.h (new) | 13 +++++++++++++
 devel/ctypes.sh/files/patch-src_callback.c (new)     | 11 +++++++++++
 devel/ctypes.sh/files/patch-src_unpack.c (new)       | 11 +++++++++++
 4 files changed, 55 insertions(+)