Bug 265467 - math/gismo: fix build on armv6/armv7
Summary: math/gismo: fix build on armv6/armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-27 18:57 UTC by Robert Clausecker
Modified: 2022-07-27 19:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
fuz: merge-quarterly?


Attachments
math/gismo: fix build on armv6/armv7 (913 bytes, patch)
2022-07-27 18:57 UTC, Robert Clausecker
fuz: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-27 18:57:28 UTC
Created attachment 235508 [details]
math/gismo: fix build on armv6/armv7

Define TARGET_ARCHITECTURE to a reasonable default value
so the port builds.

Tested with Poudriere on armv7 FreeBSD 13.1.
I also tested the armv6 path on armv7 and it built.
Please MFH if possible.

You'll have to also remove the BROKEN line; I'm building off a slightly outdated ports commit which doesn't have that one.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-07-27 19:26:16 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-27 19:27:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cc4c20c65b775f0a95be0fd92c887150b6266676

commit cc4c20c65b775f0a95be0fd92c887150b6266676
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-27 19:25:21 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-07-27 19:25:21 +0000

    math/gismo: Fix build on armv6/armv7

    PR:             265467

 math/gismo/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-27 19:27:10 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ed2471eb113a28112b33111fd0c53f1ee554c2f0

commit ed2471eb113a28112b33111fd0c53f1ee554c2f0
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-27 19:25:21 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-07-27 19:26:35 +0000

    math/gismo: Fix build on armv6/armv7

    PR:             265467
    (cherry picked from commit cc4c20c65b775f0a95be0fd92c887150b6266676)

 math/gismo/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)