Bug 265576 - lang/sbcl: Unbreak build with core compression enabled, add sb-simd
Summary: lang/sbcl: Unbreak build with core compression enabled, add sb-simd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-02 14:58 UTC by Dmitri Goutnik
Modified: 2022-08-05 07:25 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (krion)

Attachments
sbcl.diff (4.63 KB, patch)
2022-08-02 14:58 UTC, Dmitri Goutnik 		dmgk: maintainer-approval? (krion)
 Details | Diff
fix COMPRESSION for zstd and add SIMD (5.90 KB, patch)
2022-08-04 23:45 UTC, jinxiaoyong 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2022-08-02 14:58:08 UTC 
Created attachment 235635 [details]
sbcl.diff

sbcl 2.2.7 changed core compression library to zstd from zlib [1], update port to support that. Also rename ZLIB knob to COMPRESSION to better reflect what it does.

While here, add sb-simd contrib module (fixes bug #265538)

[1] https://github.com/sbcl/sbcl/blob/c321afb15b7308e28117a025972c8a220e7922be/NEWS#L37
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2022-08-03 17:14:45 UTC 
Thanks for the patch, it fails with defailt options:
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/sbcl/contrib/sb-simd.asd
Error: Missing: lib/sbcl/contrib/sb-simd.fasl
===> Error: Plist issues found.
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2022-08-03 20:19:19 UTC 
Hmm, it builds fine for me, both with default options and with COMPESSION.
Comment 3 Kirill Ponomarev freebsd_committer freebsd_triage 2022-08-04 05:51:40 UTC 
Hmm, probably some dependency is missing? I think we have to wrap sb-simd into ARCH==amd64 only
Comment 4 jinxiaoyong 2022-08-04 23:45:16 UTC 
Created attachment 235684 [details]
fix COMPRESSION for zstd and add SIMD

sb-simd is only built on CPUs that support AVX2.  Conditioning on ARCH==amd64 is not enough.  This new patch adds an additional config option SIMD.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-05 07:22:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=70419d445f16ec33270498abeb346318e3045bf1

commit 70419d445f16ec33270498abeb346318e3045bf1
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2022-08-05 07:20:36 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2022-08-05 07:20:36 +0000

    lang/sbcl: Add core compression and sb-simd module

    PR:             265576
    Reported by:    dmgk and jinxiaoyong@gmail.com

 lang/sbcl/Makefile  | 32 ++++++++++++++++++++++++++------
 lang/sbcl/pkg-plist | 31 +++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 6 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-08-05 07:22:56 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc62245938b730b0e37e1039ee10c4ebd6447fc4

commit fc62245938b730b0e37e1039ee10c4ebd6447fc4
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2022-08-05 07:20:36 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2022-08-05 07:22:44 +0000

    lang/sbcl: Add core compression and sb-simd module

    PR:             265576
    Reported by:    dmgk and jinxiaoyong@gmail.com

    (cherry picked from commit 70419d445f16ec33270498abeb346318e3045bf1)

 lang/sbcl/Makefile  | 32 ++++++++++++++++++++++++++------
 lang/sbcl/pkg-plist | 31 +++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 6 deletions(-)