Bug 265586 - emulators/darcnes: fix build on recent FreeBSD
Summary: emulators/darcnes: fix build on recent FreeBSD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-03 04:31 UTC by Robert Clausecker
Modified: 2022-08-05 05:57 UTC (History)
1 user (show)

See Also:

Attachments
emulators/darcnes: fix build on recent FreeBSD (1.22 KB, patch)
2022-08-03 04:31 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-08-03 04:31:08 UTC 
Created attachment 235647 [details]
emulators/darcnes: fix build on recent FreeBSD

The port requires GNU89 semantics for the inline keyword,
as opposed to the standard C99 semantics.  Fix the build
by setting the C standard to GNU89.

While we are at it, hook up test suite and make it work.

Same fix as bug #265511.
Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
The test suite passes on armv7, but fails on arm64 (seems to be a problem with type sizes on 64 bit platforms).
Committer may consider adding a BROKEN_arm64 at his discretion.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-05 05:57:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9df2db274cc6c2ad040ea8ce7e18c22869c3a9fb

commit 9df2db274cc6c2ad040ea8ce7e18c22869c3a9fb
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-04 05:59:22 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-05 05:54:21 +0000

    emulators/darcnes: fix build on recent FreeBSD

    The port requires GNU89 semantics.

    PR:     265586
    Reported by:    fuz@fuz.su (maintainer)

 emulators/darcnes/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-05 05:57:44 UTC 
Committed,

Thanks!