Bug 265605 - archivers/zstd: Add LTO option
Summary: archivers/zstd: Add LTO option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-03 22:33 UTC by Daniel Engberg
Modified: 2022-08-20 07:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for zstd (572 bytes, patch)
2022-08-03 22:33 UTC, Daniel Engberg 		no flags Details | Diff
Patch for zstd v2 (481 bytes, patch)
2022-08-04 06:58 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-08-03 22:33:43 UTC 
Created attachment 235660 [details]
Patch for zstd

Add LTO option, this increases performance between 5-15% on my Intel i7-3770 (amd64) and Rockchip RK3399 (arm64) with O3 (Optimized Cflags) enabled.

LTO is also enabled by default on Alpine and OpenMandriva

Tested on FreeBSD 13.1-RELEASE
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-08-04 06:58:22 UTC 
Created attachment 235665 [details]
Patch for zstd v2

Sort options
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-08-04 06:58:46 UTC 
Also, make test passes on both tested platforms
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-20 07:33:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a2f556ccbd7685fb8149f1e63a6f692d057aa4c

commit 5a2f556ccbd7685fb8149f1e63a6f692d057aa4c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-08-20 07:26:39 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-08-20 07:32:11 +0000

    archivers/zstd: Add LTO option

    Add LTO option, this increases performance between 5-15% on my test
    systems (arm64 and amd64) with optimized cflags (-03) enabled.

    LTO is also enabled by default on Alpine Linux and OpenMandriva

    PR:             265605
    Approved by:    sunpoet (maintainer timeout, 2+ weeks)

 archivers/zstd/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)