Bug 265614 - science/chemtool-devel: fix build on FreeBSD 13+
Summary: science/chemtool-devel: fix build on FreeBSD 13+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://svnweb.freebsd.org/ports/head...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-04 06:34 UTC by Robert Clausecker
Modified: 2022-08-11 13:34 UTC (History)
1 user (show)

See Also:
eduardo: merge-quarterly+


Attachments
science/chemtool-devel: fix build on FreeBSD 13+ (1.29 KB, patch)
2022-08-04 06:34 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-08-04 06:34:33 UTC
Created attachment 235664 [details]
science/chemtool-devel: fix build on FreeBSD 13+

Same fix as 4bfc3a9 for science/chemtool.

While we are at it, define LICENSE.  The license is not
shipped, but from the README it is clearly the authors
intent to have the same license as for science/chemtool.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-04 13:38:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb127c6a8da1307a823f638a0489336222bd3f10

commit cb127c6a8da1307a823f638a0489336222bd3f10
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-04 13:20:30 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-04 13:37:25 +0000

    science/chemtool-devel: Fix build on FreeBSD 13.1R and 14

     - Same fix as 4bfc3a9 for science/chemtool.
     - While we are at it, define LICENSE.  The license is not
       shipped, but from the README it is clearly the authors
       intent to have the same license as for science/chemtool.

    while I'm here:

     - cleanup Makefile
     - remove unnecessary patch and reinplace cmd
     - add EXAMPLES option
     - add missing LIB_DEPENDS and USE_GNOME deps (Q/A check)
     - adopt port

    PR:             265614

 science/chemtool-devel/Makefile                    | 31 +++++++++++------
 .../chemtool-devel/files/patch-configure (gone)    | 22 ------------
 science/chemtool-devel/pkg-plist                   | 39 ----------------------
 3 files changed, 21 insertions(+), 71 deletions(-)
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-04 13:47:18 UTC
Committed and thanks for fix.

I will keep this PR in progress for a week to make sure that there is no pkg builders problems even with poudriere testports ok, and then I MFH to Q3.

Cheers
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-08-04 16:11:13 UTC
(In reply to Nuno Teixeira from comment #2)

Thank you for the thorough clean up and for taking up this port.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-11 13:34:13 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ac6817b1750992c19942fc86e6f785fd776d74e

commit 9ac6817b1750992c19942fc86e6f785fd776d74e
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-04 13:20:30 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-11 13:32:55 +0000

    science/chemtool-devel: Fix build on FreeBSD 13.1R and 14

     - Same fix as 4bfc3a9 for science/chemtool.
     - While we are at it, define LICENSE.  The license is not
       shipped, but from the README it is clearly the authors
       intent to have the same license as for science/chemtool.

    while I'm here:

     - cleanup Makefile
     - remove unnecessary patch and reinplace cmd
     - add EXAMPLES option
     - add missing LIB_DEPENDS and USE_GNOME deps (Q/A check)
     - adopt port

    PR:             265614
    (cherry picked from commit cb127c6a8da1307a823f638a0489336222bd3f10)

 science/chemtool-devel/Makefile                    | 31 +++++++++++------
 .../chemtool-devel/files/patch-configure (gone)    | 22 ------------
 science/chemtool-devel/pkg-plist                   | 39 ----------------------
 3 files changed, 21 insertions(+), 71 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-11 13:34:34 UTC
Committed, thanks!