Created attachment 235696 [details] v1 Moin moin kde@ would like to ask for an exp-run to update devel/cmake to 3.24.0. The patch is attached and can also be found here: https://people.freebsd.org/~tcberner/patches/0001-devel-cmake-update-to-3.24.0.patch mfg Tobias
Some new failures logs: http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/ccaudio2-2.2.0_5.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/akonadiconsole-22.04.3.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/akregator-22.04.3.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/grantlee-editor-22.04.3.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/ccrtp-2.1.2.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/kms-cmake-utils-6.16.0.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/kgeotag-1.2.0.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/mono6.8-6.8.0.123_1.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/mailcommon-22.04.3.log http://pb2.nyi.freebsd.org/data/123i386-default-foo/2022-08-08_20h18m39s/logs/kreport-3.2.0_3.log
Similar new failures logs: http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/ccaudio2-2.2.0_5.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/akonadiconsole-22.04.3.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/akregator-22.04.3.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/grantlee-editor-22.04.3.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/ccrtp-2.1.2.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/kms-cmake-utils-6.16.0.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/kgeotag-1.2.0.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/mono6.8-6.8.0.123_1.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/mailcommon-22.04.3.log http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-08-08_20h18m51s/logs/kreport-3.2.0_3.log
New failures logs on amd64: http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/ccaudio2-2.2.0_5.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/akonadiconsole-22.04.3.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/akregator-22.04.3.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/grantlee-editor-22.04.3.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/ccrtp-2.1.2.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/kms-cmake-utils-6.16.0.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/hedgewars-1.0.0_9.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/kgeotag-1.2.0.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/mono6.8-6.8.0.123_1.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/zig-0.9.1.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/zig-devel-0.9.1.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/adios2-2.8.3.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/mailcommon-22.04.3.log http://package18.nyi.freebsd.org/data/123amd64-default-foo/2022-08-08_20h18m44s/logs/kreport-3.2.0_3.log
* ccrtp is unrelated to cmake (does not use cmake): ld: error: unable to find library -llpthread
(In reply to Tobias C. Berner from comment #4) I believe it is related, a dependency uses cmake
(In reply to Antoine Brodin from comment #5) ucommon probably
(In reply to Tobias C. Berner from comment #4) * deskutils/grantlee-editor * deskutils/akonadiconsole * deskutils/akregator * net/mailcommon are overcome by the update to 22.08
(In reply to Antoine Brodin from comment #6) ok, I'll take a look at that
(In reply to Antoine Brodin from comment #6) True, it's pkgconfig file is bogus: Libs: -lcommoncpp -lucommon -llpthread -ldl -lrt -lregex
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ae30a3b002584002232a6f306e3f05c564f2d3b0 commit ae30a3b002584002232a6f306e3f05c564f2d3b0 Author: Tobias C. Berner <tcberner@FreeBSD.org> AuthorDate: 2022-09-02 10:27:16 +0000 Commit: Tobias C. Berner <tcberner@FreeBSD.org> CommitDate: 2022-09-02 10:35:44 +0000 devel/ucommon: remove patch breaking pc files /usr/ports/devel/ccrtp: ld: error: unable to find library -llpthread PR: 265652 devel/ucommon/Makefile | 2 +- devel/ucommon/files/patch-cmake_CapeConfig.cmake (gone) | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-)
(In reply to commit-hook from comment #10) ^ this takes care of * devel/ccrtp * audio/ccaudio2
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=307d7f1d2865d218076e8cf9b4d772320ee08b65 commit 307d7f1d2865d218076e8cf9b4d772320ee08b65 Author: Tobias C. Berner <tcberner@FreeBSD.org> AuthorDate: 2022-09-02 11:59:49 +0000 Commit: Tobias C. Berner <tcberner@FreeBSD.org> CommitDate: 2022-09-02 11:59:49 +0000 astro/marble: add upstream fix for broken library linkage Fix link definitions with newer CMake versions LINK_PUBLIC and LINK_PRIVATE have been deprecated for many years, and SailfishOS has a newer enough CMake version now. Marble requires CMake 3.10 anyway. Without this change, cmake 3.24.0 won't find the imported targets when Marble is used as a library. PR: 265652 astro/marble/Makefile | 4 ++++ astro/marble/distinfo | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)
(In reply to commit-hook from comment #12) ^ this takes care of * textproc/kreport * graphics/kgeotag
(In reply to Tobias C. Berner from comment #13) * lang/mono6.8 built fine here
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8fac410d9ec5c59396fc8eeba9d46a13af06d8de commit 8fac410d9ec5c59396fc8eeba9d46a13af06d8de Author: Tobias C. Berner <tcberner@FreeBSD.org> AuthorDate: 2022-09-08 14:16:36 +0000 Commit: Tobias C. Berner <tcberner@FreeBSD.org> CommitDate: 2022-09-08 14:18:47 +0000 games/hedgewars: prepare for cmake-3.24 Obtained from: Arch Linux PR: 265652 games/hedgewars/Makefile | 4 ++++ 1 file changed, 4 insertions(+)
Only * lang/zig * lang/zig-devel remain to be fixed.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d7992a6596254fa03acedcd9d06900ee951745ad commit d7992a6596254fa03acedcd9d06900ee951745ad Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2022-09-12 18:37:28 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2022-09-17 10:56:01 +0000 devel/cmake*: bump to 3.24.0 Update the CMake ports to 3.24. A previous exp-run -- thanks antoine@ -- showed up new failures. That is normal for a CMake update. tcberner@ fixed most of them (in the linked PR) and lang/zig just landed. The original patch for the update came from tcberner@ as well, but I had to re-jig it after CMake was reorganized into a metaport and -core package. PR: 265652 devel/cmake-core/Makefile | 2 +- devel/cmake-core/distinfo | 6 ++-- devel/cmake-core/pkg-plist | 71 +++++++++++++++++++++++++++++++++++++++++++--- devel/cmake-doc/Makefile | 2 +- devel/cmake-doc/pkg-plist | 2 -- devel/cmake-man/Makefile | 2 +- devel/cmake/Makefile | 3 +- 7 files changed, 74 insertions(+), 14 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bdc2b54bd1d909666e6970e6464b892eea67aa3b commit bdc2b54bd1d909666e6970e6464b892eea67aa3b Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2022-09-16 22:37:06 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2022-09-17 10:56:01 +0000 lang/zig, lang/zig-devel: fix for CMake 3.24 Add the THREADS_PREFER_PTHREAD_FLAG explicitly for zig builds; these are the only two ports that need that, otherwise it would be a candidate for adding to our platform CMake flags. Without the flag, CMake 3.24 changes how pthreads are searched, and it ends up leaving out the -pthread flag from the compile. For zig, this causes the bootstrap compiler to crash immediately (it does not even reach main), which kills the build. Prior to CMake 3.24, this flag already existed, but the order in which pthreads were searched was different, and we ended up using the -pthread flag anyway. The PR is for the CMake update. This was the last blocker for it. PR: 265652 lang/zig-devel/Makefile | 3 +++ lang/zig/Makefile | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
I fixed zig and landed that along with the CMake update. Thanks antoine@ for the exp-runs.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c712bcb0fa075d64e633b12ac43f036c6cf4aa7f commit c712bcb0fa075d64e633b12ac43f036c6cf4aa7f Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2022-09-19 20:51:14 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2022-09-19 21:01:03 +0000 astro/marble: repair generated CMake files against 3.24 The CMake configuration for Marble depends on Astro (which is another software component installed by Marble itself). Previously this was not explicitly checked-for. With CMake 3.24, it is: and consumers fail because of this. Patch submitted upstream. Bump affected consumers graphics/kgeotag and textproc/kreport. PR: 265652 astro/marble/Makefile | 4 +++- astro/marble/distinfo | 4 +++- graphics/kgeotag/Makefile | 1 + textproc/kreport/Makefile | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-)