Bug 265670 - audio/fdk-aac: Use upstream release archive
Summary: audio/fdk-aac: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-06 06:26 UTC by Daniel Engberg
Modified: 2022-08-19 17:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
Patch for fdk-aac (1.12 KB, patch)
2022-08-06 06:26 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-08-06 06:26:07 UTC 
Created attachment 235715 [details]
Patch for fdk-aac

Follow Porters Handbook's USE_GITHUB section and use upstream release archive

The files are identical apart from that release archive also packs a configure script pre generated.

Compile tested on FreeBSD 13.1-RELEASE
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-08-06 08:40:41 UTC 
If I am not mistaken it was you who actually switched to GH in bug #252869. Can you clarify like why we should again go back to SF because there again might be cases where we have to get upstream patches when there is no releases?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-08-06 19:19:27 UTC 
I think we can consider fdk-aac being more or less "complete" as far as development goes. I will admit that my primary interest was switching to CMake as its usually more beneficial to us in terms of (less) maintenance and overall performance. I simply opted for GitHub as backporting and cherry picking would've been a lot more work.

Best regards,
Daniel
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-08-06 19:27:01 UTC 
Thanks for the clarification. Currently I don't see a super urgent requirement to switch the MASTER_SITES as often the src distrib and actual distrib differs; not up for a POLA. So I will keep this open and commit on next upgrade.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-08-06 19:37:36 UTC 
I was indirect reminded of this due to https://reviews.freebsd.org/D36039 (mainly because of sharing dist files)

Source files are the same or at least diff can't tell any differences on my box.
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-08-06 19:52:00 UTC 
(In reply to Daniel Engberg from comment #4)
Oops. Okiz. Give me a day or two. Today is already late for my builder. As it's still crying for more CPU power. :'(
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-08-18 08:33:30 UTC 
Friendly ping
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-08-19 17:28:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68c48e58781586881987d5efed0f9b8d804eccbc

commit 68c48e58781586881987d5efed0f9b8d804eccbc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-08-19 17:25:46 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-08-19 17:27:18 +0000

    audio/fdk-aac: Use upstream release archive

    Follow Porters Handbook's USE_GITHUB section and use upstream release
    archive

    The files are identical apart from that release archive also packs a
    configure script pre generated.

    PR:             265670
    Reported by:    diizzy

 audio/fdk-aac/Makefile | 5 +----
 audio/fdk-aac/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 7 deletions(-)