Bug 265932 - sysutils/apachetop: Clean up port
Summary: sysutils/apachetop: Clean up port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-18 18:15 UTC by Daniel Engberg
Modified: 2022-08-18 21:02 UTC (History)
1 user (show)

See Also:
lukasz: maintainer-feedback+

Attachments
Patch for apachetop (2.71 KB, patch)
2022-08-18 18:15 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-08-18 18:15:43 UTC 
Created attachment 235998 [details]
Patch for apachetop

Use upstream release archive as recommended in USE_GITHUB section in Porters Handbook. This also removes the need to run autoreconf. 
Define GNU_CONFIGURE as it uses GNU Autotools, 
Use CONFIGURE_ENV for ncurses(w) linking instead of patching configure script

Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-18 21:01:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=26adba26316b0fede5f395e5746583860e5aa27c

commit 26adba26316b0fede5f395e5746583860e5aa27c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-08-18 20:52:17 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-08-18 21:00:19 +0000

    sysutils/apachetop: Clean up port

    * Use DISTVERSION instead of PORTVERSION
    * Use upstream release archive as recommended by Porters Handbook, this
      also removes the need to run USES= autoreconf
    * Use GNU_CONFIGURE instead of HAS_CONFIGURE as this configure script uses
      GNU Autotools
    * Use CONFIGURE_ENV to tell configure script where ncurses is located
      which makes patching unnecessary.

    PR:             265932
    Reviewed by:    lukasz@wasikowski.net (maintainer)

 sysutils/apachetop/Makefile                        | 12 +++----
 sysutils/apachetop/distinfo                        |  6 ++--
 sysutils/apachetop/files/patch-configure.ac (gone) | 42 ----------------------
 3 files changed, 9 insertions(+), 51 deletions(-)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-08-18 21:02:57 UTC 
Committed, thanks for prompt review!