Bug 265966 - Security/Liblurch fails to build (New Port)
Summary: Security/Liblurch fails to build (New Port)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-21 08:11 UTC by Michael Adeyeye Oshin
Modified: 2022-08-29 23:46 UTC (History)
3 users (show)

See Also:


Attachments
Poudriere Log for Lurch (58.65 KB, text/plain)
2022-08-29 04:56 UTC, Michael Adeyeye Oshin
no flags Details
New Ports: Security/axc, Security/libomemo and Security/lurch (3.41 KB, application/gzip)
2022-08-29 05:34 UTC, Michael Adeyeye Oshin
no flags Details
Security/axc Updated (31.44 KB, text/plain)
2022-08-29 08:28 UTC, Michael Adeyeye Oshin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adeyeye Oshin 2022-08-21 08:11:53 UTC
Pidgin does not support OMEMO at present. I have created a library based on lurch. The library from https://github.com/gkdr/lurch can be successfully installed with 'gmake install'. I have now made a freebsd port from it. 

The port is committed  to GH at https://github.com/micadeyeye/freebsd-ports/tree/master/security/liblurch.

However, I encountered the below error.

❯ make -C /usr/local/opt/github/freebsd-ports/security/liblurch/ install clean
===>  License GPLv2 accepted by the user
===>   liblurch3-0.2.1_4 depends on file: /usr/local/sbin/pkg - found
=> liblurch-0.2.1.tar.gz.asc is not in /usr/local/opt/github/freebsd-ports/security/liblurch/distinfo.
=> Either /usr/local/opt/github/freebsd-ports/security/liblurch/distinfo is out of date, or
=> liblurch-0.2.1.tar.gz.asc is spelled incorrectly.
*** Error code 1

Stop.
make: stopped in /usr/local/opt/github/freebsd-ports/security/liblurch/


I have researched how to create the .asc but no luck. I have added the correct checksum into distinfo though.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2022-08-22 01:55:19 UTC
(In reply to Michael A. Oshin from comment #0)
Thanks for working on making a new port!

I create a pull request for you: https://github.com/micadeyeye/freebsd-ports/pull/1 and hope it help.

You don't really need gpg verifying stuff in the port because this can be done once when you creating or updating the port, for others the checksum in distinfo you provided should be fine.

I also removed some unnecessary parts from the Makefile. Also please note that  lurch is 0.7.0 now, you may want to use the latest version.

BTW, the better place to discuss the porting questions would be freebsd-ports mailing list: https://lists.freebsd.org/subscription/freebsd-ports

Let's move the further discussion there. Close the PR for now. Please open a new ticket or reopen this one and change the subject when the port is ready to be tested.
Comment 2 Michael Adeyeye Oshin 2022-08-29 04:56:26 UTC
Created attachment 236192 [details]
Poudriere Log for Lurch

Lurch has now been successfully built. Please see attached. Could you please guide me on how to open a PR for it?
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2022-08-29 05:14:27 UTC
(In reply to Michael A. Oshin from comment #2)
This is a PR. Let's reopen this one and use it to submit the port. Assigned to me for review.

Can you please attach a tarball of the proposed port? It should be able to build by cd /usr/ports/category/port && make check-orphans.
Comment 4 Michael Adeyeye Oshin 2022-08-29 05:34:29 UTC
Created attachment 236193 [details]
New Ports: Security/axc, Security/libomemo and Security/lurch

The three ports are tarred into one .tar.gz.
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2022-08-29 05:50:07 UTC
Did you know compress of already compressed files makes them bigger?
Comment 6 Cy Schubert freebsd_committer freebsd_triage 2022-08-29 06:12:35 UTC
The axc port attempts to install with root privileges. It should not. It must stage into $(WRKSRC}/${STAGEDIR}.

libomemo looks good and is ready to commit, I'll commit it tomorrow.
Comment 7 Michael Adeyeye Oshin 2022-08-29 08:28:17 UTC
Created attachment 236196 [details]
Security/axc Updated

(In reply to Cy Schubert from comment #6)
Sorry, I did not that nested tar files is a bad idea. I have now attached the new log for the security/axc with the required change(s). Please if all are good so that  I can reattach the compressed source files.
Comment 8 Michael Adeyeye Oshin 2022-08-29 08:32:41 UTC
Applied changes at https://github.com/freebsd/freebsd-ports/commit/659c1d887246b81868ff09b55102828597bd05df
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-08-29 15:57:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2bf1fc52aa698ebd4909c4127ad20dc4b5cbd706

commit 2bf1fc52aa698ebd4909c4127ad20dc4b5cbd706
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-08-29 15:05:31 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-08-29 15:56:44 +0000

    security/libomemo: Add new port

    libomemo implements OMEMO (XEP-0384 v0.3.0) in C. For more information
    see https://github.com/gkdr/libomemo.

    PR:             265966
    Submitted by:   Michael A. Oshin <micadeyeye at gmail.com>
    Reported by:    Michael A. Oshin <micadeyeye at gmail.com>

 security/Makefile                 |  1 +
 security/libomemo/Makefile (new)  | 26 ++++++++++++++++++++++++++
 security/libomemo/distinfo (new)  |  3 +++
 security/libomemo/pkg-descr (new) |  7 +++++++
 security/libomemo/pkg-plist (new) |  7 +++++++
 5 files changed, 44 insertions(+)
Comment 10 Cy Schubert freebsd_committer freebsd_triage 2022-08-29 23:46:40 UTC
libomemo has been committed. This ticket can be closed now.