Bug 266051 - [exp-run] openssl: install pc files
Summary: [exp-run] openssl: install pc files
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D36360
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-26 14:04 UTC by Baptiste Daroussin
Modified: 2022-10-12 09:53 UTC (History)
3 users (show)

See Also:
bapt: exp-run?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Daroussin freebsd_committer freebsd_triage 2022-08-26 14:04:47 UTC
I would like to request an exp-run for this patch which will install the openssl pc files, to ease openssl management via ports.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2022-08-26 20:03:45 UTC
Something looks incomplete:

% cat mainamd64PR266051/usr/libdata/pkgconfig/libssl.pc
prefix=/usr/
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: OpenSSL-libssl
Description: Secure Sockets Layer and cryptography libraries
Version: ${OPENSSL_VER}
Requires.private: libcrypto
Libs: -L${libdir} -lssl
Cflags: -I${includedir}

% cat mainamd64PR266051/usr/libdata/pkgconfig/openssl.pc
prefix=/usr/
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: OpenSSL
Description: Secure Sockets Layer and cryptography libraries and tools
Version: %%OPENSSL_VER%%
Requires: libssl libcrypto
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2022-08-29 15:35:45 UTC
yes sorry I pushed the wrong branch for review...

Fixed
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-09-06 07:25:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c26542c1afd4570b2eb9b86c47e697bdc2889312

commit c26542c1afd4570b2eb9b86c47e697bdc2889312
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-09-06 07:07:55 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-09-06 07:25:00 +0000

    security/openssl_tpm_engine: force target engine directory

    With the upcoming pc files for the base openssl the configure
    script detects automatically the target from the pkg-config variable
    with openssl base, it ends up not respecting prefix anymore.

    Thanksfully the configure script allows to define a target directory.

    PR:     266051

 security/openssl_tpm_engine/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-09-06 07:32:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b323fa85f15268ac44b8ff90faf90bce5d87b608

commit b323fa85f15268ac44b8ff90faf90bce5d87b608
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-08-26 14:02:09 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-09-06 07:32:02 +0000

    openssl: install pc files

    most programs in ports are looking for .pc files in order to get the
    necessary information on how to compile and link against openssl.

    The ports now also has a way to hide or force a path for pkgconf.

    Providing .pc files along with openssl in base will allow (once all
    the supported version of FreeBSD has it) so improve the framework to
    deal with openssl in base vs openssl in ports (and libressl)

    This will also greatly reduce the number of patches necessary to
    workaround the build systems which only knows how to detect where
    openssl is installed via pkgconf.

    PR:             266051
    MFC After:      3 weeks
    Reviewed by:    jkim, delphij
    Exp-run by:     antoine
    Differential Revision:  https://reviews.freebsd.org/D36360

 secure/lib/libcrypto/Makefile              |  1 +
 secure/lib/libcrypto/Makefile.inc          |  6 ++++++
 secure/lib/libcrypto/libcrypto.pc.in (new) | 12 ++++++++++++
 secure/lib/libssl/Makefile                 |  2 ++
 secure/lib/libssl/libssl.pc.in (new)       | 11 +++++++++++
 secure/lib/libssl/openssl.pc.in (new)      |  9 +++++++++
 6 files changed, 41 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-12 08:35:06 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=41067961b6f3a0b5667e40e768b7b46e4092348e

commit 41067961b6f3a0b5667e40e768b7b46e4092348e
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-08-26 14:02:09 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-10-12 08:34:03 +0000

    openssl: install pc files

    most programs in ports are looking for .pc files in order to get the
    necessary information on how to compile and link against openssl.

    The ports now also has a way to hide or force a path for pkgconf.

    Providing .pc files along with openssl in base will allow (once all
    the supported version of FreeBSD has it) so improve the framework to
    deal with openssl in base vs openssl in ports (and libressl)

    This will also greatly reduce the number of patches necessary to
    workaround the build systems which only knows how to detect where
    openssl is installed via pkgconf.

    PR:             266051
    MFC After:      3 weeks
    Reviewed by:    jkim, delphij
    Exp-run by:     antoine
    Differential Revision:  https://reviews.freebsd.org/D36360

    (cherry picked from commit b323fa85f15268ac44b8ff90faf90bce5d87b608)

 secure/lib/libcrypto/Makefile              |  1 +
 secure/lib/libcrypto/Makefile.inc          |  6 ++++++
 secure/lib/libcrypto/libcrypto.pc.in (new) | 12 ++++++++++++
 secure/lib/libssl/Makefile                 |  2 ++
 secure/lib/libssl/libssl.pc.in (new)       | 11 +++++++++++
 secure/lib/libssl/openssl.pc.in (new)      |  9 +++++++++
 6 files changed, 41 insertions(+)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-12 08:39:08 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ec07cdb9243290bb8a83ed0c7faf974c87902681

commit ec07cdb9243290bb8a83ed0c7faf974c87902681
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-08-26 14:02:09 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-10-12 08:37:53 +0000

    openssl: install pc files

    most programs in ports are looking for .pc files in order to get the
    necessary information on how to compile and link against openssl.

    The ports now also has a way to hide or force a path for pkgconf.

    Providing .pc files along with openssl in base will allow (once all
    the supported version of FreeBSD has it) so improve the framework to
    deal with openssl in base vs openssl in ports (and libressl)

    This will also greatly reduce the number of patches necessary to
    workaround the build systems which only knows how to detect where
    openssl is installed via pkgconf.

    PR:             266051
    MFC After:      3 weeks
    Reviewed by:    jkim, delphij
    Exp-run by:     antoine
    Differential Revision:  https://reviews.freebsd.org/D36360

    (cherry picked from commit b323fa85f15268ac44b8ff90faf90bce5d87b608)

 secure/lib/libcrypto/Makefile              |  1 +
 secure/lib/libcrypto/Makefile.inc          |  6 ++++++
 secure/lib/libcrypto/libcrypto.pc.in (new) | 12 ++++++++++++
 secure/lib/libssl/Makefile                 |  2 ++
 secure/lib/libssl/libssl.pc.in (new)       | 11 +++++++++++
 secure/lib/libssl/openssl.pc.in (new)      |  9 +++++++++
 6 files changed, 41 insertions(+)