Bug 266065 - irc/eggdrop: Modernize port
Summary: irc/eggdrop: Modernize port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-27 12:19 UTC by Daniel Engberg
Modified: 2022-08-27 12:41 UTC (History)
1 user (show)

See Also:
dbaio: maintainer-feedback+

Attachments
Patch for eggdrop (1.46 KB, patch)
2022-08-27 12:19 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-08-27 12:19:39 UTC 
Created attachment 236144 [details]
Patch for eggdrop

* Use upstream release archive as recommended by Porters Handbook USE_GITHUB section
* Remove MAKE_JOBS_UNSAFE and LLD_UNSAFE
* Remove obsolete CONFLICTS entry (port removed 2 years ago)

Smoke test (eggdrop -h) on FreeBSD 13.1-STABLE #0 stable/13-n251817-0c4d13c521a (amd64)

Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2022-08-27 12:22:18 UTC 
You can grab maintainership as well.
Thanks.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-08-27 12:27:58 UTC 
Want me to reset maintainership? I just made a small patch to make it follow Porters Handbook more closely. I haven't used Eggdrop in 10 years or so.
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2022-08-27 12:32:17 UTC 
(In reply to Daniel Engberg from comment #2)
yes, please
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-27 12:41:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c41280c203ecbbce7647674f8363bac2ea541335

commit c41280c203ecbbce7647674f8363bac2ea541335
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-08-27 12:37:49 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-08-27 12:37:55 +0000

    irc/eggdrop: Modernize port

    * Use upstream release archive as recommended by Porters Handbook USE_GITHUB section
    * Remove MAKE_JOBS_UNSAFE and LLD_UNSAFE
    * Remove obsolete CONFLICTS entry (port removed 2 years ago)
    * Minor cosmetic changes
    * Return port to pool

    PR:             266065
    Reviewed by:    dbaio

 irc/eggdrop/Makefile | 16 ++++------------
 irc/eggdrop/distinfo |  6 +++---
 2 files changed, 7 insertions(+), 15 deletions(-)